From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BECC2E94115 for ; Fri, 6 Oct 2023 20:46:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233559AbjJFUqz (ORCPT ); Fri, 6 Oct 2023 16:46:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233496AbjJFUqv (ORCPT ); Fri, 6 Oct 2023 16:46:51 -0400 Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 008D1C5 for ; Fri, 6 Oct 2023 13:46:49 -0700 (PDT) Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTP id oqrxqUmVaQUgRoriiqRZAL; Fri, 06 Oct 2023 20:46:48 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id orihqsQlPxsQ8orihqiHnY; Fri, 06 Oct 2023 20:46:48 +0000 X-Authority-Analysis: v=2.4 cv=fZK+dmcF c=1 sm=1 tr=0 ts=65207238 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=Dx1Zrv+1i3YEdDUMOX3koA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=bhdUkHdE2iEA:10 a=wYkD_t78qR0A:10 a=JfrnYn6hAAAA:8 a=20KFwNOVAAAA:8 a=VwQbUJbxAAAA:8 a=7CQSdrXTAAAA:8 a=QyXUC8HyAAAA:8 a=1XWaLZrsAAAA:8 a=oGMlB6cnAAAA:8 a=NEAV23lmAAAA:8 a=cm27Pg_UAAAA:8 a=Ept5xCBCDW7Vsq_-JocA:9 a=QEXdDO2ut3YA:10 a=1CNFftbPRP8L7MoqJWF3:22 a=AjGcO6oz07-iQ99wixmX:22 a=a-qgeE7W1pNrGK8U0ZQC:22 a=NdAtdrkLVvyUPsUoGJp4:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Qm71vIH8l6GmDG5pJ/nbitu7tnl1liUv4COLKheS+YY=; b=CsG2smektTqOWZ0UIsfO0TtZx2 RhVhMcDOQR3Re101Jz6zkfPPwRxgmffXTxpd3LJHnJprYroiRdKz6Nom4jM0fYdf+Akb5uoQDOIk9 AdTNdoOlLKk23UVU10O+Sm+HvlyTZ43IM7h6BWl3+dY7jPGgf9sKX3R7ZpgO+0mDj5SY75JXf2h4j J0zf0jXGC3qySoJmNt/1WHloYYrkabJxU7ScuRPQCJ5kgP4Ona6yIucZBlr9RY7szbIlUCkCyGK7p urWB3A75orMIkYHWJzfQXYgD79L/lFxzzDuJ8OQi6oPxVx4x9hPpgjUJWVVsY8VenpOT/42RDqOOd i6qF4Otw==; Received: from 94-238-9-39.abo.bbox.fr ([94.238.9.39]:47408 helo=[192.168.1.98]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.1) (envelope-from ) id 1qorid-001Bge-32; Fri, 06 Oct 2023 15:46:44 -0500 Message-ID: <853ad308-1863-43a0-ad39-f706b2b7761d@embeddedor.com> Date: Fri, 6 Oct 2023 22:46:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf/x86/rapl: Annotate struct rapl_pmus with __counted_by Content-Language: en-US To: Kees Cook , Peter Zijlstra Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Gustavo A. R. Silva" , linux-perf-users@vger.kernel.org, linux-hardening@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20231006201754.work.473-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20231006201754.work.473-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 94.238.9.39 X-Source-L: No X-Exim-ID: 1qorid-001Bge-32 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 94-238-9-39.abo.bbox.fr ([192.168.1.98]) [94.238.9.39]:47408 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 12 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBujtSO4jbKApztC6/3P+uXb4liBHBVRQjgTgDZV5F22iDlTya3aohmW7o0OLOfoTuj+3UeYGuLlHMHUmey6yym0/fPRBcyIq0HHAYQoaaoNQEqBe2Ls AOR8DcQgbcKxIDZJ8YpeW+xSfVNBEQMAmb/rbg+NGUrCZ0TARnHcmAGArSji0tGMFrh3wmATPDD5EU0EjdnCJON+oLNvUtsjHTa6fI4R0BLIl3kMiH6cX5du Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/6/23 22:17, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for > array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct rapl_pmus. > > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander Shishkin > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Ian Rogers > Cc: Adrian Hunter > Cc: Thomas Gleixner > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Cc: "H. Peter Anvin" > Cc: "Gustavo A. R. Silva" > Cc: linux-perf-users@vger.kernel.org > Cc: linux-hardening@vger.kernel.org > Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1] > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks! -- Gustavo > --- > arch/x86/events/rapl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c > index c2c37fb0a228..8d98d468b976 100644 > --- a/arch/x86/events/rapl.c > +++ b/arch/x86/events/rapl.c > @@ -115,7 +115,7 @@ struct rapl_pmu { > struct rapl_pmus { > struct pmu pmu; > unsigned int maxdie; > - struct rapl_pmu *pmus[]; > + struct rapl_pmu *pmus[] __counted_by(maxdie); > }; > > enum rapl_unit_quirk {