From: Joe Perches <joe@perches.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
linux-media <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: i2c: ov8865: Neaten unnecessary indentation
Date: Wed, 15 Dec 2021 00:07:14 -0800 [thread overview]
Message-ID: <8541216a98a1a68fe6c339096e5e148a40b414e2.camel@perches.com> (raw)
In-Reply-To: <Ybmgwo/6bQXtaT35@valkosipuli.retiisi.eu>
On Wed, 2021-12-15 at 10:01 +0200, Sakari Ailus wrote:
> Hi Joe
>
> On Tue, Dec 07, 2021 at 06:47:45AM -0800, Joe Perches wrote:
> > On Tue, 2021-12-07 at 14:24 +0200, Sakari Ailus wrote:
> > > Hi Joe (and Paul),
> >
> > > I guess this patch is fine as such but there seems to be a problem in error
> > > handling here: all regulators are disabled if there's a problem enabling
> > > one of them.
> > >
> > > Would it be possible to fix this as well?
> >
> > I've no hardware to test, so I've no idea if that's the right thing to do.
>
> I don't have the hardware either.
>
> But I can tell that you shouldn't disable a regulator you haven't enabled
> to begin with. Bugs (fixes of which probably should go to stable trees)
> need to be fixed before reworking the code.
I'm just fixing the ugly code.
You are welcome to fix what you believe to be logical defects.
prev parent reply other threads:[~2021-12-15 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 9:06 Joe Perches
2021-12-07 12:24 ` Sakari Ailus
2021-12-07 14:47 ` Joe Perches
2021-12-15 8:01 ` Sakari Ailus
2021-12-15 8:07 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8541216a98a1a68fe6c339096e5e148a40b414e2.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®