From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A74032BF41 for ; Mon, 17 Nov 2025 12:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763381407; cv=none; b=UlfhPdGtBT3htlf4Y5bxpII0zvckyX7mKYNdZO0QQWInvpXW7JyNimYii3Ey/uQHUQEhKL5AcyMcfuKx0YTYJzyCGQYtggEbnGSYG2kwh9Lef8h+PyKw4E3VKVpTGa9uXzRwtFMTSjFPZXm7SxwerNEntCbkur9P08y1dHVMql0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763381407; c=relaxed/simple; bh=efuSSjKL+m3PmEQEcTMBvuPJby2QnW/7yiQllx8UTZs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cFqzqfUPY0ADy+WCSXgXdSW2qeNTYzKFIPHZvzwflurNv5NjLqRDGxh7NtaFo/aPnw79g5de6OFOAuWoCQEkXB8T2NZ2CupL3GC16B+43uqJGactV7qNu6q/rvWK4hD6AX6TuG8dB6Pl3I2n8SwmKaE+wjgJ8iR88EioDCkhRYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NgExG8mv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gBny8Pq7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NgExG8mv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gBny8Pq7" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AHAKPZj3932626 for ; Mon, 17 Nov 2025 12:10:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4iYwG9oA1iME99ev4F64MEe7+HABQKRNZKdKfPqrzJY=; b=NgExG8mvhfViX3ZJ MdUNTLo1DrHc0SNn5ONL8SAh4PgSH7q5EIv4V/GhXogLZZk2aizP8sN2YaLLU7s0 Fj+BfXIEQb3Ron61xpPL/3JdXnGZ0bZW1whWnvLboNyQrm5MhSTQgh7O0HXzjtAs b+TBpap7q6/qHZEXvxBephuhYr7fLwaOsPXsjWxOrAxjqUEu40JnBPsgCyptld2Y nabhC6kB1Da8Z5egpJeTAu8PlfUSxqz+QxY7WVxUDhaGWiC2R9S2S669WKau8oiy bF6By+WCswahBIMMe6udTwX+RiiOvKZAEIUl2c1c+0Wr1Wr3wggRVZXXkY21MfC3 CVwd8A== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ag1v909pe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Nov 2025 12:10:05 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8823e9c63c6so16117366d6.0 for ; Mon, 17 Nov 2025 04:10:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763381404; x=1763986204; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4iYwG9oA1iME99ev4F64MEe7+HABQKRNZKdKfPqrzJY=; b=gBny8Pq7dx1gx9ijD4qEXxMqiuZ4BYYIp6mCWNFDSUVg3B6h4YMtKTk6X0Yr3+ig9V dUqSecHi11CRvwVPoIuF39ZbnMmHJfIZFvktyZ7n1nQYATfb0/mcTwXgGWQJrGgs4Hib OiTK641rpM8kKjErdRsvKc4B86ZES3AmX+iWd8OZ754ZHCRIfaV94y7CUrhtBWqT9r9m I1hR5dT5aYZQtCba/a/iYo9MstR8oaDxDONH6pjbLzvVLKrJLfqxSYltt0im3tJ+S+1l Xq0xAbKXBfF3bZmmSuq2BuvIahFAjw1dzj3NR3hPK8LGi720gvrX9ovDv5afj8qQUW1J ZwSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763381404; x=1763986204; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4iYwG9oA1iME99ev4F64MEe7+HABQKRNZKdKfPqrzJY=; b=XC8W7S6H4VCqCgKdD22y4/Zm4rAEByJ6PfkazXEY5KeBU+DwY4N8MqtaQBu7z36I7L FxTORQV5YoaWEvY7TcswAGvlvRsQQLMuogf1bLFrsHukgP03Eg1pL58HxLiw1aMMR2/r a3kQL9rO5jFRsbgfXSs0W4F0fL5AI5rQOAKbrA5L0QN9UGDRK7f3EZAKwX4dFvp5b+jQ LI80l0gxieDjp24Zdim/YsUk0hTwzW65kJwsm2bcfXQuaP+fldfhGFc9uDw/ozDCPNZv JN09eLmyZAQWLcPH9uSmXvwjgOsCnoDAqHKg+Ow11mF1eBX0AhCjTkuJGaLQuzjNJYua Ox6Q== X-Forwarded-Encrypted: i=1; AJvYcCVYNpNZbCTaXvkXO3aM6KzcW+Cr1Z0hu5pfFtloGD1RV11hhaxz8fTeo55Q1cc19d/b+KA2AgBDgbrYyJE=@vger.kernel.org X-Gm-Message-State: AOJu0YwIsazsUbsowfDihcz5edFS3BVdj1pi6EZn0c0n8R+wp/6Q4dUB zN8ChL6O8S2p5x2pxrql2SFqc9DkPdUUpYDKD4N5aNDXeF9ccJiesqygANqwaKv1uJZKkDr9VqE iRNmfF0J1oGb8ayZUmpZgOtftUGEGiPaErsGeygP6RscbjSGN8o6x1DXMnfW9CfnXvxE= X-Gm-Gg: ASbGncvOBZuaE7ql4VKqsrVLf8CbRPcFrbx/kIXEZZK/aeCqPQShYvELXKBCb366uQa xuQgCbnqZSHdsmWxjMZArC2QXWKpATR/vmhsPAj7as6KUb3DcVQsZVdfSxtmEtSUmUeybhQpeYy ZhF2nxzDvodIoTP2A6BmEp6jE+D1wDm8KaNApttmm/gOpE58VPU9RulXa3dj3yG+OGEYdwEe83H 3BoJwgxryj2T/uorJRWAQ9N3f6tU3DavxgR79hq0qzhF1PEEkEid60C06nybykRIX+oSFN+m952 lgSf0KLDeFVrzeNeBUDkuxbsuIUJNHMFT2wfVpObg4r9zRsyzTTouf9GwxOwrB8f75zYbNWIE58 atIiWXsH7ALBPXETGvX5ik1ftlARdv0KpWaHT9kAzwQ0QF94HZ3w1I5Az X-Received: by 2002:a05:622a:f:b0:4ee:1db1:a61d with SMTP id d75a77b69052e-4ee1db1b80cmr34880121cf.3.1763381403000; Mon, 17 Nov 2025 04:10:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+lM4RiA/uszIq5rz0kJglCgk2Y5+U6FHrUBKDfiMzHtGedL2M5TFrbseUbsKOh6X51HXKUg== X-Received: by 2002:a05:622a:f:b0:4ee:1db1:a61d with SMTP id d75a77b69052e-4ee1db1b80cmr34879781cf.3.1763381402354; Mon, 17 Nov 2025 04:10:02 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fb12c87sm1059268066b.31.2025.11.17.04.09.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 04:10:01 -0800 (PST) Message-ID: <8541a10d-99ca-43d2-bafa-8e33bba01382@oss.qualcomm.com> Date: Mon, 17 Nov 2025 13:09:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/dpu: disable gamma correction unit on SC7180 To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Federico Amedeo Izzo References: <20251115-dpu-fix-gc-v1-1-0a4fd718208d@oss.qualcomm.com> <6457c60a-2ede-4df8-ad82-d974690eba89@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: FQsQJc4RmJSPfK1BKRfgFyIuFB-wu3z8 X-Proofpoint-GUID: FQsQJc4RmJSPfK1BKRfgFyIuFB-wu3z8 X-Authority-Analysis: v=2.4 cv=acVsXBot c=1 sm=1 tr=0 ts=691b109d cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=e5mUnYsNAAAA:8 a=EUspDBNiAAAA:8 a=H1CbSrp5QckA0GuTRH0A:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=Vxmtnl_E_bksehYqCbjh:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE3MDEwMiBTYWx0ZWRfX5Z7fYrWpRF0R 3pOvSqEU18x/5bPwGjjb9nnI4Ek34hi2qwNhAYxkIudy8tr8Ch6/7smZLU3+YdglNfBi6AtuFhx KlN3EbJNywK13yAOewrZQShgcilN0DA090i2J6qlZH6UaH0tF3oWPcWkgvTXbf+Bh8KHlBRO7r8 wM0Hy13abnkIv0DX1nTXAC3kBvXd1au7BuslPeSkzL+SkdS/VQumI1k5n98s0zMbzTr099pg2Te UIkU0oXoLBjF9fs3WjbE1KQXwMJXTA60W5ezOUzFxGwUCMa9g65ViJ+tijuVEcnbMRLG/zwRvHm uDDrTWzKGpKZ5naQwTr4GaKjZK9VrGRO9+Rw26XBnCOj9BAF2F/Usn+/aQFrISeSbQO7j6eSZ5O TEwykZpAOFqaxwDXVUW7rQhHP1rvKA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_03,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 spamscore=0 bulkscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511170102 On 11/17/25 12:51 PM, Dmitry Baryshkov wrote: > On Mon, 17 Nov 2025 at 13:25, Konrad Dybcio > wrote: >> >> On 11/15/25 4:08 AM, Dmitry Baryshkov wrote: >>> IGT reported test failures with Gamma correction block on SC7180. >>> Disable GC subblock on SC7180 until we trage the issue. >>> >>> Cc: Federico Amedeo Izzo >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> Most likely I will squash this into the GC patch >>> --- >> >> Peeking at downstream, 7180 and 845 should have the exact same GC >> (v1.8).. it seems like there's an attempt to program it through >> REGDMA instead of regular reg access. Not sure if it's actually >> necessary or just an optimization > > I think it's mostly an optimization. > >> What tests are exactly failing? I couldn't track it down on FDO GL > > See [1] and other failed SC7180 jobs from the same pipeline. I haven't > triaged it yet, but I assume this might be related to platform > resources (it has only 2 LM blocks and only 1 DSPP). > Another possibility is that maybe we need higher CFG bus bandwidth > when writing LUT registers. > > [1] https://gitlab.freedesktop.org/drm/msm/-/jobs/87878393 igt.kms_color@gamma.log fails, we get an ENAVAIL (-119) (which doesn't seem like a good return value for this error but anyway..), dmesg says 05:42:13.199: [ 75.472174] [drm:_dpu_rm_check_lm_and_get_connected_blks] [dpu error]failed to get dspp on lm 0 05:42:13.199: [ 75.481487] [drm:_dpu_rm_make_reservation] [dpu error]unable to find appropriate mixers 05:42:13.199: [ 75.490235] [drm:dpu_rm_reserve] [dpu error]failed to reserve hw resources: -119 which comes from: idx = lm_cfg->dspp - DSPP_0; if (idx < 0 || idx >= ARRAY_SIZE(rm->dspp_blks)) { // misleading error message, it's not LM%d, but DSPP%d DPU_ERROR("failed to get dspp on lm %d\n", lm_cfg->dspp); return false; } which comes from: static const struct dpu_lm_cfg sc7180_lm[] = { { .name = "lm_0", .id = LM_0, .base = 0x44000, .len = 0x320, .features = MIXER_MSM8998_MASK, .sblk = &sc7180_lm_sblk, .lm_pair = LM_1, .pingpong = PINGPONG_0, .dspp = DSPP_0, }, { .name = "lm_1", .id = LM_1, .base = 0x45000, .len = 0x320, .features = MIXER_MSM8998_MASK, .sblk = &sc7180_lm_sblk, .lm_pair = LM_0, .pingpong = PINGPONG_1, // no dspp here, errors out }, }; would simply binding .dspp = DSPP_0 to the other one just work here? Also, would that mean we can only have gamma control on a single active LM at a time? Konrad