From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1290C0015E for ; Tue, 4 Jul 2023 06:17:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230206AbjGDGR5 (ORCPT ); Tue, 4 Jul 2023 02:17:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229595AbjGDGRz (ORCPT ); Tue, 4 Jul 2023 02:17:55 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB91DB2; Mon, 3 Jul 2023 23:17:54 -0700 (PDT) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3645mhiF024703; Tue, 4 Jul 2023 06:17:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=t0zMGzXixzJKbaGxlG+O0tWfmtuwIuzhsmMKrtHsbpY=; b=f3V3Wnx6rBHgU8IpoF8ReC7mk0aP6GVbg1eMnJrTwjGbZt/NZgy2Iu4CtRv/+9D1LBTJ G3j1iTXZEpdq3kdUlJZCSkWq1dZ667B087NnoI3c8+t62jYLRHEicbpdAN0qR97ZTbhR 07ePoKVl2DZzpdhVQPy8+IDDS0s5WyjSbFcDHt72jq7zN4d9TsUWvsHLosyey01AOl9x 8tClLssILjpc3F1XKh8ysPe1WGXCcoHaE6nVLP61oUwPp94uMMuGBoCTrzkltLSAOPFc YGWaA1E/tCgD5nG/hWkVkDUwY9nMDj4SnjfnXvNHZ5bf5nvmLXZ5ab4lpUBoNw8zLI5Y UA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rky5mhhmr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 04 Jul 2023 06:17:49 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3646HmZH013137 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 4 Jul 2023 06:17:48 GMT Received: from [10.214.27.248] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.7; Mon, 3 Jul 2023 23:17:43 -0700 Message-ID: <85456057-c4ef-68a6-4fc5-c9fd03b01b71@quicinc.com> Date: Tue, 4 Jul 2023 11:47:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75 Content-Language: en-US To: Konrad Dybcio , , , , , , , , , , CC: , , , References: <1688395346-3126-1-git-send-email-quic_rohiagar@quicinc.com> <1688395346-3126-3-git-send-email-quic_rohiagar@quicinc.com> <0d468d08-6410-e424-b4f3-5245cdb0334a@linaro.org> From: Rohit Agarwal In-Reply-To: <0d468d08-6410-e424-b4f3-5245cdb0334a@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: em-JOLUUshQTz55R4nm2ZEIJtFmYSQss X-Proofpoint-GUID: em-JOLUUshQTz55R4nm2ZEIJtFmYSQss X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-04_03,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=797 adultscore=0 spamscore=0 clxscore=1015 mlxscore=0 priorityscore=1501 phishscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307040052 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/3/2023 8:29 PM, Konrad Dybcio wrote: > On 3.07.2023 16:42, Rohit Agarwal wrote: >> Add RPM power domain bindings for the SDX75 SoC. >> >> Signed-off-by: Rohit Agarwal >> --- >> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + >> include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++ >> 2 files changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >> index afad313..58e1be8 100644 >> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >> @@ -40,6 +40,7 @@ properties: >> - qcom,sdm845-rpmhpd >> - qcom,sdx55-rpmhpd >> - qcom,sdx65-rpmhpd >> + - qcom,sdx75-rpmhpd >> - qcom,sm6115-rpmpd >> - qcom,sm6125-rpmpd >> - qcom,sm6350-rpmhpd >> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h >> index 1bf8e87..8092d0d 100644 >> --- a/include/dt-bindings/power/qcom-rpmpd.h >> +++ b/include/dt-bindings/power/qcom-rpmpd.h >> @@ -57,6 +57,14 @@ >> #define SDX65_CX_AO 4 >> #define SDX65_MXC 5 >> >> +/* SDX75 Power Domain Indexes */ >> +#define SDX75_CX 0 >> +#define SDX75_CX_AO 1 >> +#define SDX75_MSS 2 >> +#define SDX75_MX 3 >> +#define SDX75_MX_AO 4 >> +#define SDX75_MXC 5 > Please instead introduce a set of defines without the SoC prefix > (i.e. CX, CX_AO, MX etc.). We've been putting this off for too long > and you're the first unlucky guy that submitted new RPMhPD support after > we've concluded it'd be the way to go! :D Sadly, we can't replace the > existing ones retroactively.. Surely No issues. Will update it. Thanks, Rohit. > Konrad >> + >> /* SM6350 Power Domain Indexes */ >> #define SM6350_CX 0 >> #define SM6350_GFX 1