From: Bart Van Assche <bvanassche@acm.org>
To: DooHyun Hwang <dh0421.hwang@samsung.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
alim.akhtar@samsung.com, avri.altman@wdc.com,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, peter.wang@mediatek.com,
manivannan.sadhasivam@linaro.org, quic_mnaresh@quicinc.com
Cc: grant.jung@samsung.com, jt77.jang@samsung.com,
junwoo80.lee@samsung.com, jangsub.yi@samsung.com,
sh043.lee@samsung.com, cw9316.lee@samsung.com,
sh8267.baek@samsung.com, wkon.kim@samsung.com
Subject: Re: [PATCH 1/2] scsi: ufs: Add an enum for ufs_trace to check ufs cmd error
Date: Wed, 3 Sep 2025 08:56:23 -0700 [thread overview]
Message-ID: <854fad23-e7f8-42c8-b0e2-03460f481366@acm.org> (raw)
In-Reply-To: <2add01dc1c9d$7b5cba30$72162e90$@samsung.com>
On 9/2/25 11:39 PM, DooHyun Hwang wrote:
> Could you please provide some guidance or suggestions?
How about this approach?
* In a separate patch, remove UFS_DEV_COMP because it is not used.
* Call the new enumeration label UFS_UIC_ERR (UFS UIC command error)
since "UIC" is how the UFS standard refers to UIC commands (these are
called "device commands" in the UFS driver).
If anyone else has a different opinion, please speak up.
Thanks,
Bart.
next prev parent reply other threads:[~2025-09-03 15:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250417023415epcas1p47da6d269afcb5d1807004c9b708675a5@epcas1p4.samsung.com>
2025-04-17 2:34 ` [PATCH 0/2] scsi: ufs: Add an enum for ufs_trace_str_t to check uic " DooHyun Hwang
[not found] ` <CGME20250417023417epcas1p31338c05e70e61b0a5e96d0ac0910713d@epcas1p3.samsung.com>
2025-04-17 2:34 ` [PATCH 1/2] scsi: ufs: Add an enum for ufs_trace to check ufs " DooHyun Hwang
2025-04-17 4:59 ` Avri Altman
2025-04-17 8:21 ` DooHyun Hwang
2025-08-29 15:15 ` Bart Van Assche
2025-09-01 1:31 ` DooHyun Hwang
2025-09-01 14:03 ` Bart Van Assche
2025-09-02 1:09 ` DooHyun Hwang
2025-09-02 16:34 ` Bart Van Assche
2025-09-03 6:39 ` DooHyun Hwang
2025-09-03 15:56 ` Bart Van Assche [this message]
2025-09-08 7:43 ` DooHyun Hwang
2025-09-08 15:27 ` Bart Van Assche
[not found] ` <CGME20250417023419epcas1p343060855c4470f8056116a207a584956@epcas1p3.samsung.com>
2025-04-17 2:34 ` [PATCH 2/2] scsi: ufs: core: Add a trace function calling when uic command error occurs DooHyun Hwang
2025-04-17 21:35 ` Bart Van Assche
2025-04-18 4:48 ` DooHyun Hwang
2025-04-22 12:48 ` Peter Wang (王信友)
2025-04-23 6:45 ` DooHyun Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=854fad23-e7f8-42c8-b0e2-03460f481366@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cw9316.lee@samsung.com \
--cc=dh0421.hwang@samsung.com \
--cc=grant.jung@samsung.com \
--cc=jangsub.yi@samsung.com \
--cc=jt77.jang@samsung.com \
--cc=junwoo80.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=quic_mnaresh@quicinc.com \
--cc=sh043.lee@samsung.com \
--cc=sh8267.baek@samsung.com \
--cc=wkon.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®