From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout3-smtp.messagingengine.com (fout3-smtp.messagingengine.com [103.168.172.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 768E718B46B for ; Mon, 9 Sep 2024 20:43:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725914594; cv=none; b=mbBSURv7oLkmNENdELM2dWvGLviEKVd+tshTVJggJkZb8+p5R77P8sAzRc4VyA0IT8lzSRIJNF146+TiycwPMtp3j4QgQXg3YuP14tY5XaFA7GjBzir1dnyjMy920vQZS/4ONIXoU47hVXcm3GJL4NTNxZ4De/NB4CtFWvknRh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725914594; c=relaxed/simple; bh=fIetD5QJrL1r/lJhwyaLiRNRlp4jCX8fUbwbhCln5k8=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=pyEOm17eDpStpG0b/yvhuT2BdTPuwPpwWfMXR1ZVnbIKxO7cut2+yWmhB1uWzk+XJkfaA8YqEOlPC/HA04Ut7HuNR9kgQIXY09ewfT1dVNM7BvLEGu+bIb7s5Fi7DluzBMIQAghAcPD6a5sCMow4/RjtpP1T+J097MJMZRzv//s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=Oege0iBc; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Yt3Tnure; arc=none smtp.client-ip=103.168.172.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="Oege0iBc"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Yt3Tnure" Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 8109913801F9; Mon, 9 Sep 2024 16:43:11 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Mon, 09 Sep 2024 16:43:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1725914591; x=1726000991; bh=DMtOFdHnFia/5nYaAaOQk2PtM52mI11VRy3Qvnxac9g=; b= Oege0iBc1AUFW0+63y3hVAtYJ0GXoyGHZe9Clo4nCcHQb6SEww1F+k53srI0Ofd5 reVIS6WZ8QdzNT3r5EMPHeKaDjgJ9iwKCiB741PHqyD2MNszoib/0IcrkEVrSQWV wAS7v5TNbGG63zTyxy3IP/QcBktZvzuWIkPCdOfQigc5pv6uMnIJeVnmUHq7oBuA qt/bSGes0inFNnsTbn7GqgPjz5tmj0SKw/6iSPRsrH1/0Bpvizp9xPUgGGJn/kBU saNEIogp3BiCRSrZl6uMr30EdQaTGhKXWzEmHamuQab9nG5WSW6gcfBF+/DgQ09v YZJ/HHTeHaJ15BdP3YD38A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725914591; x= 1726000991; bh=DMtOFdHnFia/5nYaAaOQk2PtM52mI11VRy3Qvnxac9g=; b=Y t3Tnure0uniZCMN19u6tj2uIVjraT4Mw+6OtynZAZ3oSS2MFssIk7KFpzCekSqdc JYf+2yQVpdI9OIEluW0Ra9TPYavi4VbHHUJfdrp8SJITvMcVp2F//9h5fQrhhEvb dgE96v3j62YN+RmTCtEG5sylX4xR6EdINp6vA6d3VERPmIhGN4xjSw45y1LdDoTV o/8blvIge75AN41GjegOiLVr2n/ij5l670NCMknF88fJZKxF5UWLzoNmc7F8XcH0 lBqm5c0I0WGqGXSKEJ/om83+M6gVuQtX8uoOrt1aRyQU6dMozyFM1gI66mo8xpMK Lfshkzb29q0xtw9EIoFTg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeijedgudefiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthhqredtredt jeenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusg druggvqeenucggtffrrghtthgvrhhnpedvhfdvkeeuudevfffftefgvdevfedvleehvddv geejvdefhedtgeegveehfeeljeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggvpdhnsggprhgtphhtthhopedu jedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprghnshhhuhhmrghnrdhkhhgrnh guuhgrlhesrghrmhdrtghomhdprhgtphhtthhopeiihhhouhgthhgvnhhgmhhinhhgsegs hihtvggurghntggvrdgtohhmpdhrtghpthhtoheptghhrhhishestghhrhhishguohifnh drnhgrmhgvpdhrtghpthhtohephhgrnhhnvghssegtmhhpgigthhhgrdhorhhgpdhrtghp thhtohepnhhphhgrmhgtshesghhmrghilhdrtghomhdprhgtphhtthhopeihohhsrhihrg hhmhgvugesghhoohhglhgvrdgtohhmpdhrtghpthhtohepfihilhhlhiesihhnfhhrrggu vggrugdrohhrghdprhgtphhtthhopegrrhhnugeskhgvrhhnvghlrdhorhhgpdhrtghpth htohepkhgvvghssehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 6309B222006F; Mon, 9 Sep 2024 16:43:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Mon, 09 Sep 2024 20:42:49 +0000 From: "Arnd Bergmann" To: "Yosry Ahmed" , "Arnd Bergmann" Cc: "Andrew Morton" , "Johannes Weiner" , "Nhat Pham" , "Chris Down" , "David Hildenbrand" , "Mike Rapoport" , peterx , "Matthew Wilcox" , "Kees Cook" , "Vlastimil Babka" , "Chengming Zhou" , "Anshuman Khandual" , "Vitaly Wool" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Message-Id: <85524814-6256-4f83-bb59-879debf26646@app.fastmail.com> In-Reply-To: References: <20240909202625.1054880-1-arnd@kernel.org> Subject: Re: [PATCH] mm: z3fold: deprecated ZSWAP_ZPOOL_DEFAULT_Z3FOLD as well Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Sep 9, 2024, at 20:29, Yosry Ahmed wrote: > On Mon, Sep 9, 2024 at 1:26=E2=80=AFPM Arnd Bergmann = wrote: >> >> -config ZSWAP_ZPOOL_DEFAULT_Z3FOLD >> - bool "z3fold" >> - select Z3FOLD >> +config ZSWAP_ZPOOL_DEFAULT_Z3FOLD_DEPRECATED >> + bool "z3foldi (DEPRECATED)" >> + select Z3FOLD_DEPRECATED > > Thanks for looking into this! > > I was going to fix this by changing "select Z3FOLD" to "depends on > Z3FOLD" instead. It makes the warning go away in my builds. Does this > work for you? I had also thought about this but decided that this would make less sense from a user perspective.=20 If it builds in all configs, I won't complain though. Arnd