From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751859AbdBSRGj (ORCPT ); Sun, 19 Feb 2017 12:06:39 -0500 Received: from mail-ve1eur01on0044.outbound.protection.outlook.com ([104.47.1.44]:18337 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751534AbdBSRGg (ORCPT ); Sun, 19 Feb 2017 12:06:36 -0500 From: Majd Dibbiny To: SF Markus Elfring CC: "linux-rdma@vger.kernel.org" , Doug Ledford , Hal Rosenstock , "Leon Romanovsky" , Matan Barak , "Sean Hefty" , Yishai Hadas , LKML , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH 06/29] IB/mlx4: Delete three unnecessary return statements Thread-Topic: [PATCH 06/29] IB/mlx4: Delete three unnecessary return statements Thread-Index: AQHSiik1DbkTNrPEaU6mg/alWwTnVKFwkKsh Date: Sun, 19 Feb 2017 17:06:22 +0000 Message-ID: <85584EE0-57D5-4229-8FD1-0DBF6E296F7D@mellanox.com> References: <1935365a-bd7c-461e-6a84-0c5d3a501fff@users.sourceforge.net>,<7edfe4d6-156d-23c9-acef-a6606680a5eb@users.sourceforge.net> In-Reply-To: <7edfe4d6-156d-23c9-acef-a6606680a5eb@users.sourceforge.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=majd@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [46.121.82.152] x-ms-office365-filtering-correlation-id: 45061a05-2db8-4a61-0d71-08d458e9a386 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:VI1PR0501MB1935; x-microsoft-exchange-diagnostics: 1;VI1PR0501MB1935;7:i6q28XgJ34y92IPEsiiOBRENSyfQrzY0WK2G9tEGJk8cS5tceokzwKxv0weNbVucKi1UKvMg3wFayYfvx0SGFNDooACnyiYCKTnuC/QPX15lEs/DDfQsVwX2b0nsbKLt5dxR58rGlxNZUOjXcrlaAEe1nr227bPBHevbtA+/yyJp2sbk9ngRtod7/Eb5cQlmcAdm4Omy5giItiHozrUdQU8Hje6o/fcZSxHotPlRiaWxfmGJkb44twHqKno6YTPUY7a2Uh3WeVQIZxL3/k88NBkmiug/XOvBCXQBdG2JhyjAu2kgs6rATRoS6o10sxOj//81J3a7ppjGeo9EK3f13A== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(42262312472803); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(20161123558025)(6072148);SRVR:VI1PR0501MB1935;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0501MB1935; x-forefront-prvs: 02234DBFF6 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39450400003)(39840400002)(39850400002)(39410400002)(199003)(377454003)(189002)(24454002)(7736002)(6666003)(6916009)(92566002)(2950100002)(82746002)(66066001)(5660300001)(83716003)(305945005)(229853002)(99286003)(2906002)(3280700002)(3660700001)(4326007)(54906002)(3846002)(77096006)(25786008)(6486002)(102836003)(6506006)(6512007)(6116002)(6306002)(6436002)(101416001)(81156014)(97736004)(6246003)(8676002)(81166006)(39060400002)(110136004)(53936002)(38730400002)(966004)(8936002)(2900100001)(122556002)(106116001)(106356001)(189998001)(68736007)(36756003)(54356999)(76176999)(50986999)(105586002)(33656002)(86362001)(104396002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0501MB1935;H:DB6PR0501MB2072.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2017 17:06:22.3038 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB1935 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1JH7IWv008975 > On Feb 18, 2017, at 10:54 PM, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Fri, 17 Feb 2017 21:34:27 +0100 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: void function return statements are not generally useful > > Thus remove such a statement in the affected functions. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/mlx4/mad.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c > index d8c27e3ed69a..cf33efce69d2 100644 > --- a/drivers/infiniband/hw/mlx4/mad.c > +++ b/drivers/infiniband/hw/mlx4/mad.c > @@ -1173,7 +1173,6 @@ static void handle_slaves_guid_change(struct mlx4_ib_dev *dev, u8 port_num, > out: > kfree(in_mad); > kfree(out_mad); > - return; > } > > void handle_port_mgmt_change_event(struct work_struct *work) > @@ -2140,7 +2139,6 @@ void mlx4_ib_tunnels_update_work(struct work_struct *work) > mlx4_ib_tunnels_update(dmxw->dev, dmxw->slave, (int) dmxw->port, > dmxw->do_init); > kfree(dmxw); > - return; > } > > static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev, > @@ -2268,7 +2266,6 @@ static void mlx4_ib_master_tunnels(struct mlx4_ib_dev *dev, int do_init) > /* initialize or tear down tunnel QPs for the master */ > for (i = 0; i < dev->dev->caps.num_ports; i++) > mlx4_ib_tunnels_update(dev, mlx4_master_func_num(dev->dev), i + 1, do_init); > - return; > } > > int mlx4_ib_init_sriov(struct mlx4_ib_dev *dev) > -- > 2.11.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks, Reviewed-by: Majd Dibbiny