mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	Liam Girdwood <lgirdwood@gmail.com>, Marek Vasut <marex@denx.de>,
	kernel <kernel@dh-electronics.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V5] regulator: da9062: Make the use of IRQ optional
Date: Thu, 13 Jul 2023 17:34:24 +0100	[thread overview]
Message-ID: <8558f2aa-09fd-4cd3-ae1e-c80893e00aa1@sirena.org.uk> (raw)
In-Reply-To: <9629970cc2c3452e83a43660823319e5@dh-electronics.com>

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

On Thu, Jul 13, 2023 at 03:36:38PM +0000, Christoph Niedermaier wrote:
> From: Mark Brown [mailto:broonie@kernel.org]

> > Are there any dependencies for this patch?  The fact that I acked it
> > makes me think there were MFD parts

> It's a patch series. This patch is the last one in this series, that is
> missing to have the ability to run the DA9061/62 without a connected IRQ
> pin. The other patches are already upstreamed and yes there are MFD parts,
> see below:

Oh, dear.  Why weren't they applied, it's not even the confusion there
was over what Reviewed-by means...

> >> Reported-by: kernel test robot <lkp@intel.com>
> >> Link: https://lore.kernel.org/oe-kbuild-all/202303082246.GuLdPL0t-lkp@intel.com/

> > I really doubt that the LKP bot ran into an issue due to a system with
> > this device without an IRQ wired up...

> In V3 of this patch the kernel test robot found an issue. I had really
> overlooked that. Thanks to LKP. I forgot to replace the irq variable in
> the function devm_request_threaded_irq(). So it affected the path with
> IRQ. In V4 I fixed that. In V5 I only rebased it on the current next
> 20230713 and add Marek's Reviewed-by tag.

That doesn't mean you should include tags like this, it makes it look
like they reported the commit...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-07-13 16:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13  9:03 Christoph Niedermaier
2023-07-13 12:30 ` Mark Brown
2023-07-13 15:36   ` Christoph Niedermaier
2023-07-13 16:34     ` Mark Brown [this message]
2023-07-14 19:03       ` Christoph Niedermaier
2023-07-14 19:16         ` Mark Brown
2023-07-14 20:15           ` Christoph Niedermaier
2023-07-14 20:20             ` Mark Brown
2023-07-14 20:27               ` Christoph Niedermaier
2023-07-13 19:51 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8558f2aa-09fd-4cd3-ae1e-c80893e00aa1@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Adam.Thomson.Opensource@diasemi.com \
    --cc=cniedermaier@dh-electronics.com \
    --cc=kernel@dh-electronics.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=support.opensource@diasemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®