From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B6BC10F26 for ; Thu, 2 Apr 2020 07:31:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4E5D2078E for ; Thu, 2 Apr 2020 07:31:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387508AbgDBHbD (ORCPT ); Thu, 2 Apr 2020 03:31:03 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2629 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727012AbgDBHbD (ORCPT ); Thu, 2 Apr 2020 03:31:03 -0400 Received: from lhreml724-chm.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 1C90EA1B68B64323459F; Thu, 2 Apr 2020 08:31:01 +0100 (IST) Received: from [127.0.0.1] (10.47.6.242) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 2 Apr 2020 08:31:00 +0100 Subject: Re: [PATCH] scsi: hisi_sas: Fix build error without SATA_HOST To: YueHaibing , , , CC: , , Bartlomiej Zolnierkiewicz , References: <20200402063021.34672-1-yuehaibing@huawei.com> From: John Garry Message-ID: <855fee9e-ae2d-ca70-8630-df27a273e6f3@huawei.com> Date: Thu, 2 Apr 2020 08:30:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20200402063021.34672-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.6.242] X-ClientProxiedBy: lhreml729-chm.china.huawei.com (10.201.108.80) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/04/2020 07:30, YueHaibing wrote: + > If SATA_HOST is n, build fails: > > drivers/scsi/hisi_sas/hisi_sas_main.o: In function `hisi_sas_fill_ata_reset_cmd': > hisi_sas_main.c:(.text+0x2500): undefined reference to `ata_tf_to_fis' > > Select SATA_HOST to fix this. > > Reported-by: Hulk Robot > Fixes: 7c594f0407de ("scsi: hisi_sas: add softreset function for SATA disk") That's not right. SATA_HOST was only introduced recently in the ATA code. It would fix those kconfig changes. > Signed-off-by: YueHaibing > --- > drivers/scsi/hisi_sas/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig > index 90a17452a50d..13ed9073fc72 100644 > --- a/drivers/scsi/hisi_sas/Kconfig > +++ b/drivers/scsi/hisi_sas/Kconfig > @@ -6,6 +6,7 @@ config SCSI_HISI_SAS > select SCSI_SAS_LIBSAS > select BLK_DEV_INTEGRITY > depends on ATA > + select SATA_HOST That does not feel right. SCSI_HISI_SAS depends on ATA, but SATA_HOST also depends on ATA, so it seems better to just depend on SATA_HOST (and omit explicit ATA dependency), rather than select it. Thanks, John