mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: Lyude Paul <lyude@redhat.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
	Jani Nikula <jani.nikula@intel.com>,
	linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
	David Airlie <airlied@linux.ie>
Subject: Re: [v2,2/3] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel
Date: Tue, 03 Mar 2020 14:50:02 -0500	[thread overview]
Message-ID: <8560ac83111aed7b4cf74b96ae578682a764f5c8.camel@redhat.com> (raw)
In-Reply-To: <20200211183358.157448-3-lyude@redhat.com>

On Tue, 2020-02-11 at 13:33 -0500, Lyude Paul wrote:

> -	if (!intel_dp_aux_display_control_capable(intel_connector))
> +	/*
> +	 * There are a lot of machines that don't advertise the backlight
> +	 * control interface to use properly in their VBIOS, :\
> +	 */
> +	if (dev_priv->vbt.backlight.type !=
> +	    INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE &&
> +	    !drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks,
> +			      DP_QUIRK_FORCE_DPCD_BACKLIGHT)) {
> +		DRM_DEV_INFO(dev->dev,
> +			     "Panel advertises DPCD backlight support, but "
> +			     "VBT disagrees. If your backlight controls "
> +			     "don't work try booting with "
> +			     "i915.enable_dpcd_backlight=1. If your machine "
> +			     "needs this, please file a _new_ bug report on "
> +			     "bugs.freedesktop.org against DRI -> "
> +			     "DRM/Intel\n");

Bugzilla's been put out of our misery, probably this should point to
gitlab instead.

- ajax


  reply	other threads:[~2020-03-03 19:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 18:33 [PATCH v2 0/3] drm/dp,i915: eDP DPCD backlight control detection fixes Lyude Paul
2020-02-11 18:33 ` [PATCH v2 1/3] drm/dp: Introduce EDID-based quirks Lyude Paul
2020-03-03 19:51   ` [v2,1/3] " Adam Jackson
2020-02-11 18:33 ` [PATCH v2 2/3] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel Lyude Paul
2020-03-03 19:50   ` Adam Jackson [this message]
2020-03-03 21:53   ` [PATCH v3] " Lyude Paul
2020-02-11 18:33 ` [PATCH v2 3/3] drm/i915: Force DPCD backlight mode for some Dell CML 2020 panels Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8560ac83111aed7b4cf74b96ae578682a764f5c8.camel@redhat.com \
    --to=ajax@redhat.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®