From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756141AbcBCQXs (ORCPT ); Wed, 3 Feb 2016 11:23:48 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:52138 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752194AbcBCQXq (ORCPT ); Wed, 3 Feb 2016 11:23:46 -0500 From: Arnd Bergmann To: Zubair Lutfullah Kakakhel Cc: tj@kernel.org, hdegoede@redhat.com, david.daney@cavium.com, aleksey.makarov@caviumnetworks.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH v6] SATA: OCTEON: support SATA on OCTEON platform Date: Wed, 03 Feb 2016 17:23:18 +0100 Message-ID: <8562433.7oWe1ikqcL@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56B2247D.5040501@imgtec.com> References: <1454437485-48009-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1725737.t6I7PsvPbL@wuerfel> <56B2247D.5040501@imgtec.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:1e32mg46h9hFfsM+P/An0eiapfscu+oUjMTRmipyXTDXMw6tUsq SycpA/uhETNtYcUJ9QCQ2R9LHxUCYAwakHMUM7y2B/P/uLrs/ZZuYB1HBzGc37+Kh91bRBI sSR89pJrG4/NJW1mPJmsZRZVC5tgc/40CMOMVNfB0Bn3XOGlTzf3WpKFuMkaRZi/qKOCsBn IPbyoST7hdl8yDXX91bxw== X-UI-Out-Filterresults: notjunk:1;V01:K0:BPuFXe4GSaM=:4PTtlb7MIHg5LsYW5RflrI 9fsOG6RphgtAWa7IBJqI3MzwdSaYMii+LRedFO92vovP7qSnlAwL4LCA6kBkbARqL3IaygxBN 1pwGB8ya8NLeYVa4zlbOE0BCcIwS3Gp4V/pTFwg4e1E0tLW0sW9WiYALmMJ3f0MCoBeJTqRSv 53ivzhi6uSjyKAHeG7BrQU9ulgeU1pFXX3tJJJcHzmF/BJacHuuHVX/PH0gXW1t46Zfnk/ntj DUiQY04ME+jvaY3l6cpMGQU2Z3kKoLEkimZmWrKZ1Vw0oQ2fIY+HJyIEoM2KdW01iSpeocKDb 59YXqOWU7digfKZ+vJ+bTmSKqJYeldQudmusShueGfRbYVwcG0UfxkDvyRqZAroSTGfxyO/xz PpRcNVepE4FFqY6+iNVbyLe7O1uxSJzCiGDnfkqbSRmZiU1K4P1RjnAgyIehenzy0NgvZpGG3 m7M5YK27DzFsPK/q2eb8Y1ZASzwiieZejLZGRz/H1Ev67n6CL5vhIN24tt8DJPdBg6SOA3GQr SDMQ/MmmXL3GkHzheW64X1e+lfFdItV8LS9jnUMbDLV0gYVeQmI0yzInpLchg1T7ZJsji4Jvy tM0mcI+ChA11UlmCHBSqBReIkALJSYhma/4BI8wVOimpYg5kyxh4b7kkf2uBxbz6w07sar/Qd PJXaLztdYkjR3HPbExSq1wCSkt3ck6oAoC9BoSs6PTfkl+42IYDU+9Wn+0qNJzNFXEMRGgxCf 3vllKAhPAf6Yz8F0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 03 February 2016 16:02:05 Zubair Lutfullah Kakakhel wrote: > Hence, I find the original binding simpler and easier to understand when looking at the hardware manual > > + uctl@118006c000000 { > + compatible = "cavium,octeon-7130-sata-uctl"; > + reg = <0x11800 0x6c000000 0x0 0x100>; > + ranges; /* Direct mapping */ > + dma-ranges; > + #address-cells = <2>; > + #size-cells = <2>; > + > + sata: sata@16c0000000000 { > + compatible = "cavium,octeon-7130-ahci"; > + reg = <0x16c00 0x00000000 0x0 0x200>; > + interrupt-parent = <&cibsata>; > + interrupts = <2 4>; /* Bit: 2, level */ > + }; > + }; > > Is it possible to let this example go in as is? > I don't have the hardware manual, so I'm just guessing what the hardware looks like. If the manual describes the device as a bridge with a 1:1 mapping, then your existing example above absolutely makes sense. Arnd