From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751544AbcJAJP2 (ORCPT ); Sat, 1 Oct 2016 05:15:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55182 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750934AbcJAJPS (ORCPT ); Sat, 1 Oct 2016 05:15:18 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <201610010540.58123.arnd@arndb.de> References: <201610010540.58123.arnd@arndb.de> <12692.1475278509@warthog.procyon.org.uk> <20160930161218.4178124-1-arnd@arndb.de> <16139.1475279560@warthog.procyon.org.uk> To: Arnd Bergmann Cc: dhowells@redhat.com, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rxrpc: split up rxrpc_send_call_packet() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8567.1475313315.1@warthog.procyon.org.uk> Date: Sat, 01 Oct 2016 10:15:15 +0100 Message-ID: <8568.1475313315@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sat, 01 Oct 2016 09:15:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann wrote: > Yes, good idea. We could probably share the part of the two functions that > sets the contents of the msg and pkt variables by moving it into a third > function, but I'm not sure if that actually improves readability or just > reduces the number of lines. And the ACK-sending function is about to get a bit more complex :-( David