From: Dmitry Osipenko <digetx@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] opp: Prepare for ->set_opp() helper to work without regulators
Date: Tue, 19 Jan 2021 20:18:00 +0300 [thread overview]
Message-ID: <8568b543-99e4-628f-128b-8c990aeeb6c2@gmail.com> (raw)
In-Reply-To: <302c014726dbd9fcde852985528c139d2214a1f2.1611038066.git.viresh.kumar@linaro.org>
19.01.2021 09:35, Viresh Kumar пишет:
> Until now the ->set_opp() helper (i.e. special implementation for
> setting the OPPs for platforms) was implemented only to take care of
> multiple regulators case, but going forward we would need that for other
> use cases as well.
>
> This patch prepares for that by allocating the regulator specific part
> from dev_pm_opp_set_regulators() and the opp helper part from
> dev_pm_opp_register_set_opp_helper().
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Dmitry,
>
> I haven't tested this patch, can you please help with that ?
>
> drivers/opp/core.c | 81 ++++++++++++++++++++++++----------------------
> drivers/opp/opp.h | 2 ++
> 2 files changed, 45 insertions(+), 38 deletions(-)
Works good, thank you. It also almost looks good to me, please see my
other reply regarding the locks.
Tested-by: Dmitry Osipenko <digetx@gmail.com>
Now the set_opp() needs to be taught about the sod_supplies in order to
actually make it to work without the regulators, I'll make a patch on
top of this change.
next prev parent reply other threads:[~2021-01-19 18:28 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 0:55 [PATCH v3 00/12] OPP API fixes and improvements Dmitry Osipenko
2021-01-18 0:55 ` [PATCH v3 01/12] opp: Fix adding OPP entries in a wrong order if rate is unavailable Dmitry Osipenko
2021-01-18 7:44 ` Viresh Kumar
2021-01-18 18:46 ` Dmitry Osipenko
2021-01-18 0:55 ` [PATCH v3 02/12] opp: Filter out OPPs based on availability of a required-OPP Dmitry Osipenko
2021-01-18 8:11 ` Viresh Kumar
2021-01-18 0:55 ` [PATCH v3 03/12] opp: Correct debug message in _opp_add_static_v2() Dmitry Osipenko
2021-01-18 8:14 ` Viresh Kumar
2021-01-18 0:55 ` [PATCH v3 04/12] opp: Add dev_pm_opp_sync_regulators() Dmitry Osipenko
2021-01-18 8:20 ` Viresh Kumar
2021-01-18 18:35 ` Dmitry Osipenko
2021-01-19 4:58 ` Viresh Kumar
2021-01-19 22:42 ` Dmitry Osipenko
2021-01-18 11:00 ` Viresh Kumar
2021-01-18 11:06 ` Viresh Kumar
2021-01-18 0:55 ` [PATCH v3 05/12] opp: Add dev_pm_opp_set_voltage() Dmitry Osipenko
2021-01-18 9:52 ` Viresh Kumar
2021-01-18 19:14 ` Dmitry Osipenko
2021-01-20 21:57 ` Dmitry Osipenko
2021-01-21 11:20 ` Viresh Kumar
2021-01-18 0:55 ` [PATCH v3 06/12] opp: Add dev_pm_opp_find_level_ceil() Dmitry Osipenko
2021-01-18 9:58 ` Viresh Kumar
2021-01-18 0:55 ` [PATCH v3 07/12] opp: Add dev_pm_opp_get_required_pstate() Dmitry Osipenko
2021-01-18 10:50 ` Viresh Kumar
2021-01-18 0:55 ` [PATCH v3 08/12] opp: Add devm_pm_opp_register_set_opp_helper Dmitry Osipenko
2021-01-18 11:07 ` Viresh Kumar
2021-01-18 0:55 ` [PATCH v3 09/12] opp: Add devm_pm_opp_attach_genpd Dmitry Osipenko
2021-01-18 11:14 ` Viresh Kumar
2021-01-18 0:55 ` [PATCH v3 10/12] opp: Support set_opp() customization without requiring to use regulators Dmitry Osipenko
2021-01-18 11:44 ` Viresh Kumar
2021-01-18 18:48 ` Dmitry Osipenko
2021-01-19 6:35 ` [PATCH] opp: Prepare for ->set_opp() helper to work without regulators Viresh Kumar
2021-01-19 17:16 ` Dmitry Osipenko
2021-01-20 7:39 ` Viresh Kumar
2021-01-20 14:50 ` Dmitry Osipenko
2021-01-21 11:25 ` Viresh Kumar
2021-01-19 17:18 ` Dmitry Osipenko [this message]
2021-01-20 8:08 ` Viresh Kumar
2021-01-21 11:28 ` Viresh Kumar
2021-01-19 6:36 ` [PATCH v3 10/12] opp: Support set_opp() customization without requiring to use regulators Viresh Kumar
2021-01-21 11:30 ` [PATCH V2] opp: Prepare for ->set_opp() helper to work without regulators Viresh Kumar
2021-01-21 21:02 ` Dmitry Osipenko
2021-01-22 3:05 ` Viresh Kumar
2021-01-18 0:55 ` [PATCH v3 11/12] opp: Handle missing OPP table in dev_pm_opp_xlate_performance_state() Dmitry Osipenko
2021-01-18 11:18 ` Viresh Kumar
2021-01-18 0:55 ` [PATCH v3 12/12] opp: Print OPP level in debug message of _opp_add_static_v2() Dmitry Osipenko
2021-01-18 11:18 ` Viresh Kumar
2021-01-18 11:46 ` [PATCH v3 00/12] OPP API fixes and improvements Viresh Kumar
2021-01-19 17:35 ` Dmitry Osipenko
2021-01-20 15:41 ` Dmitry Osipenko
2021-01-21 7:51 ` Viresh Kumar
2021-01-21 20:30 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8568b543-99e4-628f-128b-8c990aeeb6c2@gmail.com \
--to=digetx@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®