From: Yuehaibing <yuehaibing@huawei.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: <perex@perex.cz>, <tiwai@suse.com>, <broonie@kernel.org>,
<rfontana@redhat.com>, <kstewart@linuxfoundation.org>,
<allison@lohutok.net>, <armijn@tjaldur.nl>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH -next] ALSA: Au88x0 - remove some unused const variables
Date: Fri, 9 Aug 2019 18:00:01 +0800 [thread overview]
Message-ID: <85696583-655b-06dd-d851-c8bfdaab7924@huawei.com> (raw)
In-Reply-To: <s5hk1bmhe9t.wl-tiwai@suse.de>
On 2019/8/9 17:35, Takashi Iwai wrote:
> On Fri, 09 Aug 2019 11:06:20 +0200,
> YueHaibing wrote:
>>
>> sound/pci/au88x0/au88x0_xtalk.c:121:28: warning: asXtalkWideCoefsRightXt defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:152:28: warning: asXtalkNarrowCoefsRightXt defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:175:28: warning: asXtalkCoefsNegPipe defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:183:28: warning: asXtalkCoefsNumTest defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:191:28: warning: asXtalkCoefsDenTest defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:199:28: warning: asXtalkOutStateTest defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:20:20: warning: sXtalkWideKRightXt defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:231:28: warning: asDiamondCoefsRightXt defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:24:20: warning: sXtalkWideShiftRightXt defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:30:20: warning: sXtalkNarrowKRightXt defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:34:20: warning: sXtalkNarrowShiftRightXt defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:38:28: warning: asXtalkGainsDefault defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:43:28: warning: asXtalkGainsTest defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:48:28: warning: asXtalkGains1Chan defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:67:28: warning: alXtalkDlineTest defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:77:30: warning: asXtalkInStateTest defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:92:20: warning: sDiamondKRightXt defined but not used [-Wunused-const-variable=]
>> sound/pci/au88x0/au88x0_xtalk.c:96:20: warning: sDiamondShiftRightXt defined but not used [-Wunused-const-variable=]
>
> Some of them are rather a bug, likely the wrong register and data is
> used (left instead of right). They have to be fixed instead of
> removing.
>
> And some are indeed unused, but I'd leave them with ifdef or such.
> Such magical values do have some meaning (as the driver code was the
> result from reverse-engineering) and blindly removing it also loses
> the information -- though, the driver is tad old and likely broken, so
> practically seen no big impact.
Agree, just leave them this, Thanks!
>
>
> thanks,
>
> Takashi
>
> .
>
prev parent reply other threads:[~2019-08-09 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 9:06 YueHaibing
2019-08-09 9:35 ` [alsa-devel] " Takashi Iwai
2019-08-09 10:00 ` Yuehaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85696583-655b-06dd-d851-c8bfdaab7924@huawei.com \
--to=yuehaibing@huawei.com \
--cc=allison@lohutok.net \
--cc=alsa-devel@alsa-project.org \
--cc=armijn@tjaldur.nl \
--cc=broonie@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rfontana@redhat.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®