From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753762AbcD2PMv (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Apr 2016 11:12:51 -0400
Received: from pygmy.kinoho.net ([134.0.27.24]:35797 "EHLO pygmy.kinoho.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753114AbcD2PMu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Apr 2016 11:12:50 -0400
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Fri, 29 Apr 2016 17:12:48 +0200
From: Grigori Goronzy <greg@chown.ath.cx>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, Johan Hovold <jhovold@gmail.com>
Subject: Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations
In-Reply-To: <20160429125239.GH22229@localhost>
References: <1460754856-27908-1-git-send-email-greg@chown.ath.cx>
 <1460754856-27908-5-git-send-email-greg@chown.ath.cx>
 <20160429125239.GH22229@localhost>
Message-ID: <856a45c97aff7ce525e1bb3e1dee3f2f@chown.ath.cx>
User-Agent: Roundcube Webmail/1.1.3
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016-04-29 14:52, Johan Hovold wrote:
>> @@ -168,9 +168,9 @@ static int ch341_set_handshake(struct usb_device 
>> *dev, u8 control)
>> 
>>  static int ch341_get_status(struct usb_device *dev, struct 
>> ch341_private *priv)
>>  {
>> -	char *buffer;
>> +	unsigned char *buffer;
>>  	int r;
>> -	const unsigned size = 8;
>> +	const unsigned size = 2;
> 
> Did you reply to Oliver's comment about this change? Are you sure this
> won't break some old device expecting to be asked for eight bytes even
> if only two are returned?
> 

I'll just drop this change.

Grigori