From: Lyude Paul <lyude@redhat.com>
To: huzhi001@208suo.com, bskeggs@redhat.com, kherbst@redhat.com,
airlied@gmail.com, daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/nouveau/fifo:Fix Nineteen occurrences of the gk104.c error: ERROR: : trailing statements should be on next line
Date: Fri, 14 Jul 2023 19:07:10 -0400 [thread overview]
Message-ID: <856d1130fad58062ea454da297fa64348382bda2.camel@redhat.com> (raw)
In-Reply-To: <0ad4154429aaa41ca26da859c3f35784@208suo.com>
NAK - checkpatch.pl is a (strongish) guideline, but not a rule. In the cases
corrected in the patch series here, we format the switch cases on single lines
as it dramatically improves the readability of what is otherwise just a /long/
list of slightly different static mappings. I don't believe we're the only
part of the kernel to do this either.
On Fri, 2023-07-14 at 14:58 +0800, huzhi001@208suo.com wrote:
> Signed-off-by: ZhiHu <huzhi001@208suo.com>
> ---
> .../gpu/drm/nouveau/nvkm/engine/fifo/gk104.c | 40 ++++++++++++++-----
> 1 file changed, 29 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c
> index d8a4d773a58c..b99e0a7c96bb 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c
> @@ -137,15 +137,29 @@ gk104_ectx_bind(struct nvkm_engn *engn, struct
> nvkm_cctx *cctx, struct nvkm_chan
> u64 addr = 0ULL;
>
> switch (engn->engine->subdev.type) {
> - case NVKM_ENGINE_SW : return;
> - case NVKM_ENGINE_GR : ptr0 = 0x0210; break;
> - case NVKM_ENGINE_SEC : ptr0 = 0x0220; break;
> - case NVKM_ENGINE_MSPDEC: ptr0 = 0x0250; break;
> - case NVKM_ENGINE_MSPPP : ptr0 = 0x0260; break;
> - case NVKM_ENGINE_MSVLD : ptr0 = 0x0270; break;
> - case NVKM_ENGINE_VIC : ptr0 = 0x0280; break;
> - case NVKM_ENGINE_MSENC : ptr0 = 0x0290; break;
> - case NVKM_ENGINE_NVDEC :
> + case NVKM_ENGINE_SW:
> + return;
> + case NVKM_ENGINE_GR:
> + ptr0 = 0x0210;
> + break;
> + case NVKM_ENGINE_SEC:
> + ptr0 = 0x0220;
> + break;
> + case NVKM_ENGINE_MSPDEC:
> + ptr0 = 0x0250;
> + break;
> + case NVKM_ENGINE_MSPPP:
> + ptr0 = 0x0260;
> + break;
> + case NVKM_ENGINE_MSVLD:
> + ptr0 = 0x0270;
> + break;
> + case NVKM_ENGINE_VIC:
> + ptr0 = 0x0280; break;
> + case NVKM_ENGINE_MSENC:
> + ptr0 = 0x0290;
> + break;
> + case NVKM_ENGINE_NVDEC:
> ptr1 = 0x0270;
> ptr0 = 0x0210;
> break;
> @@ -435,8 +449,12 @@ gk104_runl_commit(struct nvkm_runl *runl, struct
> nvkm_memory *memory, u32 start,
> int target;
>
> switch (nvkm_memory_target(memory)) {
> - case NVKM_MEM_TARGET_VRAM: target = 0; break;
> - case NVKM_MEM_TARGET_NCOH: target = 3; break;
> + case NVKM_MEM_TARGET_VRAM:
> + target = 0;
> + break;
> + case NVKM_MEM_TARGET_NCOH:
> + target = 3;
> + break;
This one isn't very long, but I'd still say it's definitely a lot easier to
read in the compact form. If anything, the only change I would make here is
formatting the default: case to be on a single line as well
> default:
> WARN_ON(1);
> return;
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
next prev parent reply other threads:[~2023-07-14 23:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_0FA6AE16A21AAA2E9481C6FE598BA70CC405@qq.com>
2023-07-14 3:51 ` [PATCH] drm/nouveau/fifo:Fix Nineteen occurrences of the gk104.c error: ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxE) ERROR: space prohibited before that ':' (ctx:WxE) ERROR: trailing statements should be on next line ERROR: trailing s tatements " huzhi001
2023-07-14 5:14 ` huzhi001
[not found] ` <6f8d6649-5b53-4a44-8b9e-0ffd00af3fb6@app.fastmail.com>
2023-07-25 6:10 ` [Nouveau] [PATCH] drm/nouveau/fifo:Fix Nineteen occurrences of the gk104.c error: ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxE) ERROR: space prohibited before that ':' (ctx:WxE) ERROR: trailing statements should be on next line ERROR: trail Luna Jernberg
2023-07-14 5:17 ` [PATCH] drm/nouveau/fifo:Fix Nineteen occurrences of the gk104.c error: ERROR: space prohibited before that ':' (ctx:WxW) ERROR: : trailing statements should be on next line huzhi001
2023-07-14 5:21 ` [PATCH] drm/nouveau/fifo:Fix Nineteen occurrences of the gk104.c error: " huzhi001
2023-07-14 6:58 ` huzhi001
2023-07-14 23:07 ` Lyude Paul [this message]
2023-07-15 9:23 ` Karol Herbst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=856d1130fad58062ea454da297fa64348382bda2.camel@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@gmail.com \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=huzhi001@208suo.com \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome