From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B87204418CC for ; Tue, 9 Jun 2026 15:05:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781017533; cv=none; b=VrFuv/KfOyYuNNFS8hADmNPPR003DWlUaTrLN0xIBcMI2UYrrw71/A7LO2GcasCqT99Vw8BRgYQqA//ev2m5wG9NBgU/+h6o3lEeLKfJVmZ6WGIgt098vazOPKvMEd0ZJVb6ncrx5JOtQOYzSGGUdDybqJY1iqc8BPgDM57pP4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781017533; c=relaxed/simple; bh=J6xr6hQjMPqZ15jNGtmoGr4MI51kAa9A+B0VSXNVazw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PAQyIY03bZDvCinSbiodjmT4pMjQVOUu/cTuawkrg05X4J9R87LpuxQg4xAdA0Gvq+YAQ/B/2O0sGSx4Y4ucbZHMx/9zky7WbjLZNOGYaMJgPaT8VA4HktG5eVBxjkiM3MGLXUqNvOQ69BeQP6LFxNgScxvyVQTdlK2opmmDY2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=zc/W5tZd; arc=none smtp.client-ip=209.85.160.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="zc/W5tZd" Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-44192448b56so916826fac.2 for ; Tue, 09 Jun 2026 08:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1781017531; x=1781622331; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3lagboJHSs25ChzuYkvLlxQjyW9/PAyU2SUmQJq5dsk=; b=zc/W5tZd5g3gBF9Lr967i0nn48NecAmzk4L9GUin8dbEvFSG+Z/ivtkVZ+T8MmDjli AD/eNDDQ415MazVJBd/qRetiSA1pcBRk5sVjs8KRrYGA8SQM3XVoOB0auM++AmHy3wxU KZqOFup1Em5jWD2iVPdLe1BzYAzIbdSLHxaQfZtIZyj4NC9pMGKom8STnl6H9Y/P3KiT VRvzHVaMMjUla4+8t9kBDaZ1FhZo6O4VFbMXn5zjJNyqalo5ULTSiPSzxtAAdRccvcpV AXkN6RLg2Zvztrfk9gS41RpGqP/bwe7oNqfYp52U/+VVUCklnoHQ9niSpysT7FCAZRko gIQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781017531; x=1781622331; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3lagboJHSs25ChzuYkvLlxQjyW9/PAyU2SUmQJq5dsk=; b=Pzp6ZjMzZNHkOYUik52vxdis+Lb0HU295Mk0LQnMoQL7n0DHt6IXzKlg1xYN+45CkD bm+XoPGu+pwcuHsVFWF+b6FvnJjGy7RG51MWyJ9JyJwsy5lY9Zw0daTXgNtcn/ZTxWAZ CQLkIkHFALwWMvS7i0YAfXwna8D8x2wkO+whXftPyX83DMkzHd1KakL9jXHvIBYc2x/c s3DtO14THfO0XsKfDdyMgAXVrmlkny9cNKGNqrOlG6CQcCsgCHWQ4uFQKEvlT7FZX/BV rGjvjntzH02LVfD7nelXBvwsvFS0T8rjbRUwDBNmcnX5NUsxcIlG5nJ2E4aauJqQuqk1 Ip8g== X-Forwarded-Encrypted: i=1; AFNElJ/9HicLWZuWC4jHbmBmRoJ8NliDZE+l23AWULzH+Wlp+UAVJGctHy6peJ2tHGMjXvbl5S3j7GRbpICAzg0=@vger.kernel.org X-Gm-Message-State: AOJu0YwRBQ3/yj3l6wQky4Vmj48ciJOTlxwl1IGGumfNr8M6vi431cLn KNOmwbG7pUP4CV9XZOAuXMw4lonkFqODy20iFNIOIao58IJwgjjnuoxu8968h3PGMStVoCf3X/Y mr8qs X-Gm-Gg: Acq92OGWAAIIjsjuumyUpQOuvSkoxI4iLwFzJuDZonclsR06TtfESsIfLZRHL0gdumo bYLbTGQPItbPV6CSTRQ3HR+guAyoF7psYPtLUTXVk97HN5eSAU9IK+ulSbv5erMwUxNV3wUZQm/ F/mSH9fHkvfkVInEvD54BGcCqMDMKENnJwSh3oOXSXH5ubioWIHa1jXQWcSrA/Wj4YArA0vwwRL s0g+xdE72TGZB1UgVIj9C4Ha78N1KiM65D7+zm9roVIx6OilK/jWLW2nFRin0dPTOA4MZ6UXuz7 jkRxWuT4uSw9+VfsOYDi2qM9A7IjR1a7r67IOYYW8IG4PHoARcfDho6EIQ4T6bubDglM8GX8hY/ cwgSXOtdz8ewayNS2f9cfEWwzMQOuriACYiqkozmvIFTOnvt2ThDaKKdHuUtZCcc4QHhUyxmL2S mRMNHU4g5Ju8AV/3YbYG0BD++UWBpcLpf0a4ACikrtmT6zYR1x2XsC+eNW4V0BSr6yiT2we0CnD Me34GF8iUOeZYc5PWM= X-Received: by 2002:a05:6870:5486:b0:42f:d09d:1fc9 with SMTP id 586e51a60fabf-4413dcfbb82mr11317469fac.32.1781017530504; Tue, 09 Jun 2026 08:05:30 -0700 (PDT) Received: from [192.168.1.102] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-440d7263efcsm19450933fac.0.2026.06.09.08.05.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 08:05:29 -0700 (PDT) Message-ID: <8572a148-3b73-4de0-ac98-74b66e3d7ffe@kernel.dk> Date: Tue, 9 Jun 2026 09:05:29 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] block: fix arg type in `blk_mq_update_nr_hw_queues` To: Andreas Hindborg , Bart Van Assche Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260608-update-hw-nodes-arg-v1-1-19aba440b32e@kernel.org> <5353c4b0-fc3b-4fa7-bcd6-c8cc490699ea@acm.org> <87qzmggn43.fsf@kernel.org> Content-Language: en-US From: Jens Axboe In-Reply-To: <87qzmggn43.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/9/26 1:59 AM, Andreas Hindborg wrote: >> If this patch does not change the behavior of the code for any practical >> use case that would be good to mention. > > The patch does not change behavior of the code as long as no overflows > occur, and they are not likely to occur. I will be sure to add that to > the commit message. > > I came across this while designing the Rust API for these functions. > Rust is kind of particular about integer types, so it gave me some > checks/casts on the Rust side that really should no be required. I was > thinking we might as well change the type on the C side to unsigned when > the data it carries really should be unsigned. The change itself is fine imho, but I agree with Bart that the commit messages should be phrased very differently. It's not a fix, it's a cleanup that makes your life simpler on the rust side. -- Jens Axboe