From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5027EC7618D for ; Thu, 6 Apr 2023 12:53:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238125AbjDFMxG (ORCPT ); Thu, 6 Apr 2023 08:53:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238016AbjDFMxC (ORCPT ); Thu, 6 Apr 2023 08:53:02 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A956B49CE for ; Thu, 6 Apr 2023 05:53:00 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id y15so50666968lfa.7 for ; Thu, 06 Apr 2023 05:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680785579; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lbC+iDQolRLSwOunJ/j7FQP3aZrBUa7C2T5gWVYhv6I=; b=zvpzUfUNH0GaukXLBpAPf+hyShEdxGxtOyRluKQdxEtL4QovW/AkW/ylzw1ZaXMDtA k/3W7Pick4ECwKGVjnf06RQCkdb0mN2xE5IeE5sv9Gw2IIutccQwQx/++EOHPlzdMsH6 GsjLFOKt7NNvQhsfj8bEYMC27jBNpDMUcg91xXE1rK0VCaBb+iA0U8R/0NIO1JRQKZ2m LPtPSJirHSB05LBpEne3q/R8NhgqnwbqW+Plwu7B8Bst4cKi8Sd/lyZiZVytq/9e9P70 kPjQK++aERFwC1g5gXjSODs39UIli3d8luM642smqM6GgAauZWGZh+n0ekiDfxoBeyrW TNZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680785579; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lbC+iDQolRLSwOunJ/j7FQP3aZrBUa7C2T5gWVYhv6I=; b=AXqFWavFcf1zHZUyQmu5wh+B2TFN8Kp2cauaM3HubLtEZBhSPXh+aBe59/kr4bR7J0 f3do8qLx+emq+dcBteJpYd/i2Ne8YrTwBjPX4+80NaIgQxJ+92Q9q/+YpVuRp2cpcysp LDufi3v7clWdPBHxw4qHtYToqZ7vd7ydrRkfz8Wvxg/DbFz5YKq+57YOaPr1RJLDzir3 e5ZfyDoKZDRgUWUG6NetpDrdvCDOPdquzMDQ457aILOzOwFnEtWMww7mHg4kLd5wfX+n EZTPjd8ahXdaOAROz0+ED39qVekBwgHtwaAqySJxtOdFSt4dRJoohoxa5Zxj7WkXCO3a h4Gg== X-Gm-Message-State: AAQBX9cJWvZowpSGPBpGZpz0Su16cPTJax3Ryold65vg9fKRDyngvf9m CTE9BLRz6vA/6hZd4VwN75/iNg== X-Google-Smtp-Source: AKy350b/+CKd1ZodmBJD15FdPa3PXTOhvJljgBnSb42oOTa4LlbkXPdGlX4ifOYVKBresOlnli8ugA== X-Received: by 2002:a19:ae03:0:b0:4ec:5648:70e4 with SMTP id f3-20020a19ae03000000b004ec564870e4mr158178lfc.12.1680785578924; Thu, 06 Apr 2023 05:52:58 -0700 (PDT) Received: from [192.168.1.101] (abxh37.neoplus.adsl.tpnet.pl. [83.9.1.37]) by smtp.gmail.com with ESMTPSA id y2-20020ac24462000000b004db1a7e6decsm249856lfl.205.2023.04.06.05.52.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 05:52:58 -0700 (PDT) Message-ID: <857aa6c9-3dcb-d5f7-14bb-6c69c9167b09@linaro.org> Date: Thu, 6 Apr 2023 14:52:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 1/2] dt-bindings: net: Convert ATH10K to YAML Content-Language: en-US To: Rob Herring Cc: Eric Dumazet , linux-wireless@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org, Paolo Abeni , Rob Herring , netdev@vger.kernel.org, Bjorn Andersson , Kalle Valo , Andy Gross , Marijn Suijten , linux-arm-msm@vger.kernel.org, Jakub Kicinski , ath10k@lists.infradead.org References: <20230406-topic-ath10k_bindings-v2-0-557f884a65d1@linaro.org> <20230406-topic-ath10k_bindings-v2-1-557f884a65d1@linaro.org> <168078494959.2736424.13312532374051031538.robh@kernel.org> From: Konrad Dybcio In-Reply-To: <168078494959.2736424.13312532374051031538.robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6.04.2023 14:47, Rob Herring wrote: > > On Thu, 06 Apr 2023 13:54:04 +0200, Konrad Dybcio wrote: >> Convert the ATH10K bindings to YAML. >> >> Dropped properties that are absent at the current state of mainline: >> - qcom,msi_addr >> - qcom,msi_base >> >> qcom,coexist-support and qcom,coexist-gpio-pin do very little and should >> be reconsidered on the driver side, especially the latter one. >> >> Somewhat based on the ath11k bindings. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../bindings/net/wireless/qcom,ath10k.txt | 215 ------------ >> .../bindings/net/wireless/qcom,ath10k.yaml | 359 +++++++++++++++++++++ >> 2 files changed, 359 insertions(+), 215 deletions(-) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.example.dtb: wifi@18800000: wifi-firmware: 'wifi-firmware' does not match any of the regexes: 'pinctrl-[0-9]+' > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.example.dtb: wifi@18800000: wifi-firmware: 'iommus' is a required property > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml > > doc reference errors (make refcheckdocs): > MAINTAINERS: Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230406-topic-ath10k_bindings-v2-1-557f884a65d1@linaro.org Oh, CHECK_DTBS=1 doesn't run dt_binding_check and I didn't run that explicitly before resending.. my bad.. Konrad > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >