From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7EEF2AD2D for ; Mon, 24 Feb 2025 09:27:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740389256; cv=none; b=RAxlTI6NGhZ8xbmnc0/+zTzNIt9zyojEvEcfsjgTMgB+L3gkgliJ/qHH855C3fTJ5ubWtkMdgunLkalqVn3wMC1+uAqMmM7uC4uM1X1kIVy2jJM3v9sTilaLuR/w8LBlqxEt1nKbOGeW5wl0ARLdVhnpLfBc3ez8x6p66fmzBDw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740389256; c=relaxed/simple; bh=I8ik0VnxEst77sjXmH68GWfeYOl9b9AYZW0gqNH3qq0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TyhAkhvldyOYreA29HLw74gx9Hdx5tqCje9ONMDtbBPAGLg1K6m+s2gd9sbQReXFpuf+/Q+7I7X5Uwm12FISpZwdy7W0PnQwOErspruOsvH+8CRjeDAKPyzlRd0LHDbwmALIJhXJrSIBKqSAHw0urLqUgn2q7fXiT/6z85WQJhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LhQZ7zMN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LhQZ7zMN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740389253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7Zn6SZZblvU2KN6afeUfX6cSk2JfetNjQceFn+mshcA=; b=LhQZ7zMN1PnH3HP6UVwxv1qizF+3xK2DahzQlWgAExvPFWHytJSTFqX6UWYuRRNI+yORB9 C3t2zkdhnwbi9WGyGesNfpDQZETcn7SniaN3WfXUGYenvBQ3pollrwxsugc2k+UrCA9FP9 yqcDjnZvuIuNb09uG/9A6Tnouiw5eAw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-a1AqiMkbP0GlKM7_tJS2YQ-1; Mon, 24 Feb 2025 04:27:32 -0500 X-MC-Unique: a1AqiMkbP0GlKM7_tJS2YQ-1 X-Mimecast-MFC-AGG-ID: a1AqiMkbP0GlKM7_tJS2YQ_1740389251 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38f51a3a833so1586516f8f.2 for ; Mon, 24 Feb 2025 01:27:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740389251; x=1740994051; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7Zn6SZZblvU2KN6afeUfX6cSk2JfetNjQceFn+mshcA=; b=QpvPqXw+nbJeu7kixc+dfDVmNYeHtHJ7E/Odkvf51KuPUkJZxCn48iUQ6zVQA4WxTK 0HwBwqfN80tEZTkcfuWAdMQTmA5/lzHDQH2Qg1ZmMyXgejPUJE9BCvxlM31TfV+bTmJH tqpqYhkPl8nYE6kdwc4cIo7PbQAWvcJRp41jQby9q4Sv8I28G9wjch1ET/eBADaKGKrR MYPseYbbmqQ+AYygxZnYOh05apAGYSmAwdt9jJRh4Z5wb6TC939y9bAiRrA+CaND+cC4 qPxCUNUHzk1sILTCmUpFAvOI6s8EdC/OFh/eRzn5A/8P8URcuCauCwRcvbMEWfeDs7+q amOA== X-Forwarded-Encrypted: i=1; AJvYcCXB1W8Z2aZJZEsUcnnAOJos0fM+zE5Zk5DwWJd4XBQZWyGarh0LFa3xsN1xKJnyOjnH5sugRaJgkv5kQBs=@vger.kernel.org X-Gm-Message-State: AOJu0YzfFWyCh1b5c8Ptas6DLUKZ1paEOFKXeQZWPJzICg694dz9TNEM li07sbBr/GVUftr5pFOTlU0mpQeKRwcIgFNvE++vKC2zjtwQShcxpq577IfDQpycvPGYnw9BMOl /zMH4bi7mVOonLKfifii5/+4eCTuqfSaur6Rd1RRWMUemwj4y/T+MuF1Py2+ytA== X-Gm-Gg: ASbGncuHg0fZtdUNhMPQLbMwT5yeCcTAGyrW1OPHWtojgIlu5fyt8EqaM1Gs1BYE1TV PB8OO8b0WAj2ROH4y0x0Un4v8zSrwvCUDvZ+ffBwNkbA7ixDHoRsyp5DtBCHTfJcgtnBzkIn0+o t3cXutFWq3tl9mFf3j++h/XIQdJnAnQKE5pdkGv+tg8GIX99SnK1BV7Q3N4HcTfGtoTOM/HUXpO kdsUiJDwgzvnUeEyBVFiPbrV77VSuEp22Epg8kavznWCbgVw9XXs7fmjQcdYIO6mgA77/rP6glN SiIcVfIdE4csWOlRPL0TM/Vyh5U63imSfpYpUWQj0U3HfbJJzFC9wmPxhdQljZNMpHK+mT1InRq sodgSFnVH6fdDv3bhUiuCwNgq36WIF/Kpbva7MInbL9A= X-Received: by 2002:a5d:59a7:0:b0:38d:e304:7478 with SMTP id ffacd0b85a97d-38f7082b185mr12874188f8f.38.1740389251250; Mon, 24 Feb 2025 01:27:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5HbPThRylS4ilKU1oY0b9sapnTNZTmqh2oQkysSGqBLm2fMAB+eMOTjT2FNPL02czMER6nQ== X-Received: by 2002:a5d:59a7:0:b0:38d:e304:7478 with SMTP id ffacd0b85a97d-38f7082b185mr12874144f8f.38.1740389250835; Mon, 24 Feb 2025 01:27:30 -0800 (PST) Received: from ?IPV6:2003:cb:c735:1900:ac8b:7ae5:991f:54fc? (p200300cbc7351900ac8b7ae5991f54fc.dip0.t-ipconnect.de. [2003:cb:c735:1900:ac8b:7ae5:991f:54fc]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f25a0fa38sm31629174f8f.98.2025.02.24.01.27.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 01:27:30 -0800 (PST) Message-ID: <857b2c3f-7be7-44e8-a825-82a7353665fb@redhat.com> Date: Mon, 24 Feb 2025 10:27:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] fs/proc/task_mmu: add guard region bit to pagemap To: Lorenzo Stoakes , Andrew Morton Cc: Jonathan Corbet , Shuah Khan , Suren Baghdasaryan , Kalesh Singh , "Liam R . Howlett" , Matthew Wilcox , Vlastimil Babka , "Paul E . McKenney" , Jann Horn , Juan Yescas , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org References: <521d99c08b975fb06a1e7201e971cc24d68196d1.1740139449.git.lorenzo.stoakes@oracle.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <521d99c08b975fb06a1e7201e971cc24d68196d1.1740139449.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21.02.25 13:05, Lorenzo Stoakes wrote: > Currently there is no means by which users can determine whether a given > page in memory is in fact a guard region, that is having had the > MADV_GUARD_INSTALL madvise() flag applied to it. > > This is intentional, as to provide this information in VMA metadata would > contradict the intent of the feature (providing a means to change fault > behaviour at a page table level rather than a VMA level), and would require > VMA metadata operations to scan page tables, which is unacceptable. > > In many cases, users have no need to reflect and determine what regions > have been designated guard regions, as it is the user who has established > them in the first place. > > But in some instances, such as monitoring software, or software that relies > upon being able to ascertain the nature of mappings within a remote process > for instance, it becomes useful to be able to determine which pages have > the guard region marker applied. > > This patch makes use of an unused pagemap bit (58) to provide this > information. > > This patch updates the documentation at the same time as making the change > such that the implementation of the feature and the documentation of it are > tied together. > > Signed-off-by: Lorenzo Stoakes > --- Acked-by: David Hildenbrand Something that might be interesting is also extending the PAGEMAP_SCAN ioctl. See do_pagemap_scan(). The benefit here might be that one could effectively search/filter for guard regions without copying 64bit per base-page to user space. But the idea would be to indicate something like PAGE_IS_GUARD_REGION as a category when we hit a guard region entry in pagemap_page_category(). (the code is a bit complicated, and I am not sure why we indicate PAGE_IS_SWAPPED for non-swap entries, likely wrong ...) -- Cheers, David / dhildenb