From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76170B672 for ; Mon, 17 Nov 2025 12:34:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763382872; cv=none; b=Fi8kXjjR6hPn1sVtp4bo3gyMVteWXo/VV6V/+yVIAOS2JFquYHsOJT2d+u1UTUq7j+1b+tU9WEB8H3q4kgnoNBcvKf4Oet5jDjD1Rp5CF9yWvaysbR3pNhV/Z5l5L0N+9ZPl2mFk/p6ZDByD1DboCBbhH2xYv+xuEJNcK7yndnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763382872; c=relaxed/simple; bh=5N/WUSFs05AZ2ayhBYFMKXz45KQct40AYkjaJyMyUd4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rZMa2+J3lUKM5V5Dx5ezrC4KEcrND/23h7zoSY7MktEkCyEo04uFsQ8Kv1BA7CI1n8/oFy0HKzaWFRCjYQMDFZ7FuX8CJ+i1NByG61HZbNpkeUDJj14RYsSe+sOr7D7otYAWKg1Bx1FhUSZqf/nbQ4a08OFnYx8406hB5JhFKzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fNjL+tPK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iHQ6of59; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fNjL+tPK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iHQ6of59" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AHBPfx42910588 for ; Mon, 17 Nov 2025 12:34:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= w389bHTtzU7y5+ESoIMlR1+oTu9Rf9QOelpon9+5P70=; b=fNjL+tPKYlqxtDyT kbZuvTUVNJU/avGr7U1cdL+y3KGaecNgq+4P4s0wLzmAMx3WnZsZReSuWx+AgTqR 7t17twreo5v2rHRDzeW9h5l45zeSO9LDthtXCcfklgG4iI0jHgLO+S55ZBsk+dXN JwCYj0JmUFegLYa+UbLZbDlcgIsFGt3yqmiTGp99Ot1MxWLdJsqKZGptQxMex1Nr 4nwYhpG8RZNDunlQhUZD7wmT+ZIlLc4ZR2ti45wR/eNsxZsahEPXP/5YZolz0YFC zuOgHpNeHO1m+Nq1JTvQA+oFWmxWxzp03do+WgVuNbeDAE7hiwGdIflIH0Ghjd5l t+AwpA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aejgccpu4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Nov 2025 12:34:30 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ede0bd2154so16048691cf.1 for ; Mon, 17 Nov 2025 04:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763382869; x=1763987669; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=w389bHTtzU7y5+ESoIMlR1+oTu9Rf9QOelpon9+5P70=; b=iHQ6of59LXrwvi150YWGZIKwaa1OXPraDzHk2k/fXbzhInUWFCC7cXI26fl3Io6CI3 ci/EAtLBmS+eW2r+4RGdTllEW0eLvIg/oJUeKW6/K6AsmPmx3eq5begna6bB7Fuyy7N3 8dLlFVuJD+TUtH8WdO8E9JcS+pUX7XWm552ZioqDc6rc/pK9FFVSl0nrYIouygREIP5b SpXZAcdeDTKz26LkjxGJOxh3SwuXLT+6YK37Q0r+bUdg9K31On0RN3v66ko4m7zoC8lj 596mPD01D0g27HBbYjr4b0/pmFz+cO5lc540Mn13btp/XKfjnKXOEwPXkSKxF6uFFWgb 8VZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763382869; x=1763987669; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w389bHTtzU7y5+ESoIMlR1+oTu9Rf9QOelpon9+5P70=; b=u3mP7uHD8z8c1crGNi3hQnkWiK4WoAparbi1wlV2psokN1sidyTZtMDw3Qb/7Ta7bV qgp/4Gw3IGDDwB504NQJGUp3V3QPg5eEXNAjxM6m2O1uFTb+vGClKYsC2cT8U3abPZDp fMFC+CBxXpPa9YXLp1XjMChfzDlW8/QIvFw+DwoucDOTTnp9HsJA8R8FFO815aprHtwt bX7zSxRK9I5gva/caHxiqO+hAStcJct/1nmNtog8o6lJaB6Sibi37ScKMYQSXRaHjJuh Hh3/rsOvFTR5ajhYLfibnRvbSJgAgNLpZacVQX2RRMNuikSNPCkVjM9tpWGAxJTQpCpj 3yXg== X-Forwarded-Encrypted: i=1; AJvYcCUeAxcrNY3SySZT3F07y2wr9hWF+YFZXrz5F+oTnBNgj0wTu8g+VevSAtxAubKtVpCLCc0BmtooKBjACzo=@vger.kernel.org X-Gm-Message-State: AOJu0YyrTeQ6eQ9e01ryfLhZxkBqzkInheZsk+l4ksyyaPmJc/Pab8bm PQ2m1jky0Mr+Jo2q0R/DzMUXI+CLl3BMcG9ge8EizdnrbfRtuDE+2dJI1RhFnTLFhgHLFYwyggD GTXwLQXMcwgX/1zQ2CbbBlonoxKxmzgz1M1NJ9m9O0Vit383kONkqDJwrP8IfCJnFyb4= X-Gm-Gg: ASbGncvwasJJctGsyMlH30HnkDQs+QDH/t1GZ2OrojiOtBTGOEy9LochyzefhcxAvLC KuGBDxaV7emk3ufYPoh7R2G10i+UcuDyLBGwanI9mwS+ZLTAle+FKjBJpORJgTBZACVa0318Idv AfTvq116lY+lj0hrRxkYSfO+Xu+W1zeLQuqH1MOZ7uLtdlBtlmvU4+SGoqXGh9D2zlzY/oOLS07 amc7gkw2vVQddgBOLzGhuSmJWb0lRtOV9bau0TEOaPr5eJlGm9vhzLBsr4iPtRy74N0Zdv8it31 vfAeOCXo1PJps7JTgT6caL/SsUCi9zhfwjP6rH1zKKxyIAe0PQrsiNdZh47saytAi/gzBDlPSLd tAwwdmgW8lSZhpEtRSuHr/0nKfApHoUrQAYt+JLVrsoLYtVyWPxPYmNJG X-Received: by 2002:ac8:5ac5:0:b0:4ed:7f85:225c with SMTP id d75a77b69052e-4edf36e8070mr115889281cf.10.1763382869394; Mon, 17 Nov 2025 04:34:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/kyEjga6WhwlrGj52pKFpE2X/U0hipfE1znU6np/fizT9tp18cKnra0nyXXpo2tjrupwu+A== X-Received: by 2002:ac8:5ac5:0:b0:4ed:7f85:225c with SMTP id d75a77b69052e-4edf36e8070mr115889111cf.10.1763382869007; Mon, 17 Nov 2025 04:34:29 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fdaa15asm1046301966b.57.2025.11.17.04.34.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 04:34:28 -0800 (PST) Message-ID: <8580c092-3e1f-4b53-8330-ac1746b7a126@oss.qualcomm.com> Date: Mon, 17 Nov 2025 13:34:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] soc: qcom: rpmh: Add support to read back resource settings To: "Maulik Shah (mkshah)" , Kamal Wadhwa , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251022-add-rpmh-read-support-v2-0-5c7a8e4df601@oss.qualcomm.com> <20251022-add-rpmh-read-support-v2-2-5c7a8e4df601@oss.qualcomm.com> <9e8b47d8-9a20-40da-a6eb-cdd167c108dd@oss.qualcomm.com> <5029600e-a3b8-4aec-a374-526fb3f6417e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <5029600e-a3b8-4aec-a374-526fb3f6417e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Dx85LQ9k4Mrv3PM8awgQkc1FmhoIfKCH X-Proofpoint-GUID: Dx85LQ9k4Mrv3PM8awgQkc1FmhoIfKCH X-Authority-Analysis: v=2.4 cv=PJECOPqC c=1 sm=1 tr=0 ts=691b1656 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=JJSNccE5FFmdhRU14skA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE3MDEwNiBTYWx0ZWRfX2jrRctE498dr pnnlYZ6STuqcqjHVJzA38BMyl9Vva6c9fPieUnX6Q/HDelB5cxfzeSqRSfuL0YBkkq+WNB9Jprq wcUwFX1b/VIPo+OOl4K4ycnXi/okXhVQJ0SHOjN6ILIsPq+KNQDrX0vEuWO1SOzxoq0a9Okuatw bUnsqDLzo2sAuakMPjCUPbAKVwVEyRGHo3LQ4SyVVLzWjk1UE16gufudihs6RX+B6HvOlpa+kSd 1SK2iJyeJgfnbSUHmO0c25AjCFOL2lzffsWct+aFULv/nxNuTB3TlgtUW/mprYO2l/IaSKEYD+/ KhK7Lme7W7D02+McstvP/2Cs+Rc4xeML6krBxZowitdgKbk0NRguxWJPELCUI+HMnkdsGAyMKq/ 6JsUAr8MsWAwjoBZZokFtKs0P08Gbg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_03,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511170106 On 11/17/25 9:26 AM, Maulik Shah (mkshah) wrote: > > > On 11/12/2025 4:56 PM, Konrad Dybcio wrote: >> On 10/21/25 11:08 PM, Kamal Wadhwa wrote: >>> From: Maulik Shah >>> >>> All rpmh_*() APIs so far have supported placing votes for various >>> resource settings but the H/W also have option to read resource >>> settings. >>> >>> This change adds a new rpmh_read() API to allow clients >>> to read back resource setting from H/W. This will be useful for >>> clients like regulators, which currently don't have a way to know >>> the settings applied during bootloader stage. >>> >>> Link: https://lore.kernel.org/r/20250623-add-rpmh-read-support-v1-1-ae583d260195@oss.qualcomm.com >>> Signed-off-by: Maulik Shah >>> Signed-off-by: Kamal Wadhwa >>> --- >> >> [...] >> >>> +int rpmh_read(const struct device *dev, struct tcs_cmd *cmd) >>> +{ >>> + DECLARE_COMPLETION_ONSTACK(compl); >>> + DEFINE_RPMH_MSG_ONSTACK(dev, RPMH_ACTIVE_ONLY_STATE, &compl, rpm_msg); >>> + int ret; >>> + >>> + ret = __fill_rpmh_msg(&rpm_msg, RPMH_ACTIVE_ONLY_STATE, cmd, 1, true); >>> + if (ret) >>> + return ret; >>> + >>> + ret = __rpmh_write(dev, RPMH_ACTIVE_ONLY_STATE, &rpm_msg); >> >> Is there a reason for making this ACTIVE_ONLY? > > Yes, using ACTIVE_ONLY makes the read request place immediately to read back the current resource setting. > Sleep/Wake are H/W based trigger and are not applicable for this API. Huh? So if I send a read request with e.g. SLEEP_STATE, it would only get fulfilled upon an active->sleep transition? Konrad