From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-429653-1516227445-2-15297434153884935415 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='utf-8' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516227445; b=wcCR7xi1i18T+ywEZqA/tS1s8f8ohN7segX+u3g9+LZJ9GU 5RnbGk93RzbX6IVUgEW+Mn5lNUgZQc6+DOIuh4pCcRttVQP32vXLcXKTAWoY2MqI aA3GJztyNzdqw6Dhpsgl+lGcISrb97eCL7+g9DT0YB19S4Oaa1r7Yi6/oMHytZ0b gDkBA2rkFO3HSV6e2hMdYBJFh+VCepIn1W+5dG2R+boKvTv//Xms2M/RUujkJgRB MZJo8QDzCq3xRToniq/Hugp9HtpfBMxiH6uys9UgthTlxF/YP6vGmQNHYxY5756R uLscTnGCNbxm0d3ebQIKE0ar8xus8YUFGvsul+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:cc:references:from:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1516227445; bh=TSvr1n5KV5+lx2C4Ymdbl6d1wtgxDj6n182PKdYScig=; b=d CrTGFFc2HKjCMQvzjFvlMbW+qMt5syY9fMNE7nJyt7v3f4ptDM+b+U/Z6pPteI6P 7ROWGcWCg8ZdO9jVecxNhbgzSOhE9ad5uqm1Fxk4vXUvhEt2VSBn1Pq5DYO3x+xr Wua022vSSeLwe0m26ru1uCiYX79mSYQIUCZDJ90P2rZILpfnA+LjkO7+wuMWnK/F pBnObqQpA7AhszaLM4WxId3wai/K5xO/M+fwcu7QsOYM0ExQIzWeNPeRmmbHzn0L 5EpZPo93KaDTBJIAhY7jGOmaGw6l91aR8L0PcoY5Pk3Gig+tZdUG/8cfaiuvktjG jib4m9WjTf88vLAgot3Vw== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=canonical.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=canonical.com header.result=pass header_is_org_domain=yes Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=canonical.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=canonical.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753337AbeAQWRX (ORCPT ); Wed, 17 Jan 2018 17:17:23 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:41444 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752659AbeAQWRX (ORCPT ); Wed, 17 Jan 2018 17:17:23 -0500 Subject: Re: [REGRESSION][v4.14.y][v4.15] x86/intel_rdt/cqm: Improve limbo list processing To: Thomas Gleixner , "Yu, Fenghua" Cc: "Shankar, Ravi V" , "vikas.shivappa@linux.intel.com" , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Luck, Tony" , "peterz@infradead.org" , "eranian@google.com" , "ak@linux.intel.com" , "davidcc@google.com" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "1733662@bugs.launchpad.net" <1733662@bugs.launchpad.net>, "Roderick W. Smith" References: <84b8d891-6217-f56d-8ec0-313f7eb317c9@canonical.com> <159B72D0-06FE-4925-A11A-1F8A7741BF70@intel.com> <3E5A0FA7E9CA944F9D5414FEC6C7122075908855@FMSMSX153.amr.corp.intel.com> From: Joseph Salisbury Message-ID: <85822005-a3e5-a8eb-32a0-1dacd3af9804@canonical.com> Date: Wed, 17 Jan 2018 17:16:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 01/16/2018 01:59 PM, Thomas Gleixner wrote: > On Tue, 16 Jan 2018, Yu, Fenghua wrote: >>> From: Thomas Gleixner [mailto:tglx@linutronix.de] >> Is this a Haswell specific issue? >> >> I run the following test forever without issue on Broadwell and 4.15.0-rc6 with rdt mounted: >> for ((;;)) do >> for ((i=1;i<88;i++)) do >> echo 0 >/sys/devices/system/cpu/cpu$i/online >> done >> echo "online cpus:" >> grep processor /proc/cpuinfo |wc >> for ((i=1;i<88;i++)) do >> echo 1 >/sys/devices/system/cpu/cpu$i/online >> done >> echo "online cpus:" >> grep processor /proc/cpuinfo|wc >> done >> >> I'm finding a Haswell to reproduce the issue. > Come on. This is crystal clear from the KASAN trace. And the fix is simple enough. > > You simply do not run into it because on your machine > > is_llc_occupancy_enabled() is false... > > Thanks, > > tglx > > 8<-------------------- > > diff --git a/arch/x86/kernel/cpu/intel_rdt.c b/arch/x86/kernel/cpu/intel_rdt.c > index 88dcf8479013..99442370de40 100644 > --- a/arch/x86/kernel/cpu/intel_rdt.c > +++ b/arch/x86/kernel/cpu/intel_rdt.c > @@ -525,10 +525,6 @@ static void domain_remove_cpu(int cpu, struct rdt_resource *r) > */ > if (static_branch_unlikely(&rdt_mon_enable_key)) > rmdir_mondata_subdir_allrdtgrp(r, d->id); > - kfree(d->ctrl_val); > - kfree(d->rmid_busy_llc); > - kfree(d->mbm_total); > - kfree(d->mbm_local); > list_del(&d->list); > if (is_mbm_enabled()) > cancel_delayed_work(&d->mbm_over); > @@ -545,6 +541,10 @@ static void domain_remove_cpu(int cpu, struct rdt_resource *r) > cancel_delayed_work(&d->cqm_limbo); > } > > + kfree(d->ctrl_val); > + kfree(d->rmid_busy_llc); > + kfree(d->mbm_total); > + kfree(d->mbm_local); > kfree(d); > return; > } Hi Thomas, Testing of your patch shows that your patch resolves the bug.  Thanks for the assistance!  Is this something you could submit to mainline? Thanks, Joe