From: Juergen Gross <jgross@suse.com>
To: Yuho Choi <dbgh9129@gmail.com>
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
thorsten.blum@linux.dev, jason.andryuk@amd.com,
alhouseenyousef@gmail.com, kees@kernel.org, darwi@linutronix.de,
jpoimboe@kernel.org, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org, alhouseenyoursef@gmail.com
Subject: Re: [PATCH v1] xenbus: Unregister reboot notifier on init failure
Date: Thu, 13 Aug 2026 12:46:40 +0200 [thread overview]
Message-ID: <85897ca5-77ae-4b05-89c2-8b1619845c48@suse.com> (raw)
In-Reply-To: <20260807032326.940377-1-dbgh9129@gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 589 bytes --]
On 07.08.26 05:23, Yuho Choi wrote:
> xs_init() registers xs_reboot_nb before initializing XenStore
> communications and starting xenwatch. If either operation fails, the
> notifier remains registered and a later initialization attempt can hit a
> duplicate registration.
>
> Check the notifier registration result and unregister it on every
> subsequent failure path.
>
> Fixes: fd8aa9095a95 ("xen: optimize xenbus driver for multiple concurrent xenstore accesses")
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
prev parent reply other threads:[~2026-08-13 10:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 3:23 Yuho Choi
2026-08-13 10:46 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85897ca5-77ae-4b05-89c2-8b1619845c48@suse.com \
--to=jgross@suse.com \
--cc=alhouseenyoursef@gmail.com \
--cc=alhouseenyousef@gmail.com \
--cc=darwi@linutronix.de \
--cc=dbgh9129@gmail.com \
--cc=jason.andryuk@amd.com \
--cc=jpoimboe@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=thorsten.blum@linux.dev \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®