From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22EE2C4360C for ; Fri, 4 Oct 2019 08:34:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0176C215EA for ; Fri, 4 Oct 2019 08:34:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729999AbfJDIej (ORCPT ); Fri, 4 Oct 2019 04:34:39 -0400 Received: from mga06.intel.com ([134.134.136.31]:47704 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726024AbfJDIei (ORCPT ); Fri, 4 Oct 2019 04:34:38 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2019 01:34:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,255,1566889200"; d="scan'208";a="275974766" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.66]) ([10.237.72.66]) by orsmga001.jf.intel.com with ESMTP; 04 Oct 2019 01:34:36 -0700 Subject: Re: [PATCH 0/6] perf scripts python: exported-sql-viewer.py: Add Time chart by CPU To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , linux-kernel@vger.kernel.org References: <20190821083216.1340-1-adrian.hunter@intel.com> <6f55cdb7-a431-bd1b-8e7f-f8caf92399af@intel.com> <20191003132531.GA9369@kernel.org> <20191003134340.GB9369@kernel.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <858ae8fb-bbc8-a739-a507-6e8ddf1ef3ee@intel.com> Date: Fri, 4 Oct 2019 11:33:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191003134340.GB9369@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/10/19 4:43 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 03, 2019 at 10:25:31AM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Thu, Oct 03, 2019 at 02:01:16PM +0300, Adrian Hunter escreveu: >>> On 6/09/19 11:57 AM, Adrian Hunter wrote: >>>> On 21/08/19 11:32 AM, Adrian Hunter wrote: >>>>> Hi >>>>> >>>>> These patches to exported-sql-viewer.py, add a time chart based on context >>>>> switch information. Context switch information was added to the database >>>>> export fairly recently, so the chart menu option will only appear if >>>>> context switch information is in the database. Refer to the Exported SQL >>>>> Viewer Help option for more information about the chart. >>>>> >>>>> >>>>> Adrian Hunter (6): >>>>> perf scripts python: exported-sql-viewer.py: Add LookupModel() >>>>> perf scripts python: exported-sql-viewer.py: Add HBoxLayout and VBoxLayout >>>>> perf scripts python: exported-sql-viewer.py: Add global time range calculations >>>>> perf scripts python: exported-sql-viewer.py: Tidy up Call tree call_time >>>>> perf scripts python: exported-sql-viewer.py: Add ability for Call tree to open at a specified task and time >>>>> perf scripts python: exported-sql-viewer.py: Add Time chart by CPU >>>>> >>>>> tools/perf/scripts/python/exported-sql-viewer.py | 1555 +++++++++++++++++++++- >>>>> 1 file changed, 1531 insertions(+), 24 deletions(-) >>>> >>>> Any comments? >>>> >>> >>> ping >> >> Nice stuff, but please next time, when you add a new UI accessible >> visualization, provide precise steps to collect, then generate the DB >> and finally run the GUI, so that interested people (like me, when >> testing) can follow those instructions and compare the result described >> to the graph the test would see following these instructions. >> >> I'm trying to do that now. > > The F1 help text helps in that direction, but only once you're in the > GUI. > > I did limited testing this time, couldn't get what is in the help text > in the GUI, close but not exactly, I'm applying, since this doesn't > affects anything outside these scripts and I think that if some set of > instructions, which I encourage you to detail next time, are followed, > then the expected result looks promising. Thanks for applying.