From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520AbeDTRxL (ORCPT ); Fri, 20 Apr 2018 13:53:11 -0400 Received: from merlin.infradead.org ([205.233.59.134]:55174 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752682AbeDTRxJ (ORCPT ); Fri, 20 Apr 2018 13:53:09 -0400 Subject: Re: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain. To: Mario Limonciello , dvhart@infradead.org, Andy Shevchenko Cc: LKML , platform-driver-x86@vger.kernel.org References: <1524246131-17621-1-git-send-email-mario.limonciello@dell.com> From: Randy Dunlap Message-ID: <858fbd0a-a387-e9f8-5017-1fff9638dd4d@infradead.org> Date: Fri, 20 Apr 2018 10:53:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1524246131-17621-1-git-send-email-mario.limonciello@dell.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/20/18 10:42, Mario Limonciello wrote: > As reported by Randy Dunlap: >>> WARNING: unmet direct dependencies detected for DELL_SMBIOS >>> Depends on [m]: X86 [=y] && X86_PLATFORM_DEVICES [=y] >>> && (DCDBAS [=m] || >>> DCDBAS [=m]=n) && (ACPI_WMI [=n] || ACPI_WMI [=n]=n) >>> Selected by [y]: >>> - DELL_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] >>> && DMI [=y] >>> && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] || >>> ACPI_VIDEO [=n]=n) >>> && (RFKILL [=n] || RFKILL [=n]=n) && SERIO_I8042 [=y] >>> > > Right now it's possible to set dell laptop to compile in but this > causes dell-smbios to compile in which breaks if dcdbas is a module. > > Dell laptop shouldn't select dell-smbios anymore, but depend on it. > > Fixes: 32d7b19 (platform/x86: dell-smbios: Resolve dependency error on DCDBAS) meta-comment: the SHA-1 ID should be the first 12 characters of the commit ID according to Documentation/process/submitting-patches.rst. > Reported-by: Randy Dunlap > Signed-off-by: Mario Limonciello Tested-by: Randy Dunlap Thanks. > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 39d06dd..bc309c5 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -154,7 +154,7 @@ config DELL_LAPTOP > depends on ACPI_VIDEO || ACPI_VIDEO = n > depends on RFKILL || RFKILL = n > depends on SERIO_I8042 > - select DELL_SMBIOS > + depends on DELL_SMBIOS > select POWER_SUPPLY > select LEDS_CLASS > select NEW_LEDS > -- ~Randy