From: Jason Wang <jasowang@redhat.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
syzbot <syzbot+d21e6e297322a900c128@syzkaller.appspotmail.com>,
KVM list <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
virtualization@lists.linux-foundation.org, weiyj.lk@gmail.com
Subject: Re: INFO: task hung in vhost_net_stop_vq
Date: Tue, 9 Apr 2019 11:31:44 +0800 [thread overview]
Message-ID: <858fcd87-071f-e484-7d2d-a7d9f8144f91@redhat.com> (raw)
In-Reply-To: <CACT4Y+Z1s-Lx1UXHKj88kQoOcbiD8gwyuRU3F_+cceP3pzbbrw@mail.gmail.com>
On 2019/3/26 下午6:28, Dmitry Vyukov wrote:
> On Tue, Mar 26, 2019 at 11:17 AM Jason Wang<jasowang@redhat.com> wrote:
>> On 2019/3/25 下午10:02, Michael S. Tsirkin wrote:
>>> Looks like more iotlb locking mess?
>> Looking at the calltrace:
>>
>> [ 221.743675] =============================================
>> [ 221.744297] [ INFO: possible recursive locking detected ]
>> [ 221.744944] 4.7.0+ #1 Not tainted
>> [ 221.745326] ---------------------------------------------
>> [ 221.746128] syz-executor1/6823 is trying to acquire lock:
>> [ 221.746737] (&vq->mutex){+.+...}, at: [<ffffffff84484b70>] vhost_process_iotlb_msg+0xe0/0x9e0
>> [ 221.747789]
>> [ 221.747789] but task is already holding lock:
>> [ 221.748470] (&vq->mutex){+.+...}, at: [<ffffffff84484b70>] vhost_process_iotlb_msg+0xe0/0x9e0
>> [ 221.749535]
>> [ 221.749535] other info that might help us debug this:
>> [ 221.750280] Possible unsafe locking scenario:
>> [ 221.750280]
>> [ 221.750946] CPU0
>> [ 221.751232] ----
>> [ 221.751523] lock(&vq->mutex);
>> [ 221.751922] lock(&vq->mutex);
>> [ 221.752339]
>> [ 221.752339] *** DEADLOCK ***
>> [ 221.752339]
>>
>> I could not think of a path that can hit this. And I could not reproduce with the reproducer in the link in net-next.
> Looking at the bisection log, syzbot is able to reproduce this
> super-reliably on multiple kernel revisions. Are you sure you are
> using the right config/revision? What else can be in play? syzbot uses
> VMs. The image is available.
>
>
Yes, looks like the reason is vhost accept zero size iova range which
lead a infinite loop when trying to translate iova. Will post a patch to
fix this.
Thanks
prev parent reply other threads:[~2019-04-09 3:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 22:32 syzbot
2019-03-20 5:21 ` syzbot
2019-03-25 14:02 ` Michael S. Tsirkin
2019-03-26 10:17 ` Jason Wang
2019-03-26 10:28 ` Dmitry Vyukov
2019-04-09 3:31 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=858fcd87-071f-e484-7d2d-a7d9f8144f91@redhat.com \
--to=jasowang@redhat.com \
--cc=dvyukov@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=syzbot+d21e6e297322a900c128@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=weiyj.lk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome