From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034296AbdD1B2X (ORCPT ); Thu, 27 Apr 2017 21:28:23 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:33424 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034265AbdD1B2O (ORCPT ); Thu, 27 Apr 2017 21:28:14 -0400 Subject: Re: [PATCH] watchdog: bcm281xx: Fix use of uninitialized spinlock. To: Eric Anholt , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org References: <20170428010232.19905-1-eric@anholt.net> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Ray Jui , Scott Branden From: Florian Fainelli Message-ID: <8592b4ab-3277-d8ef-a227-91ad30f05328@gmail.com> Date: Thu, 27 Apr 2017 18:28:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170428010232.19905-1-eric@anholt.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/27/2017 06:02 PM, Eric Anholt wrote: > The bcm_kona_wdt_set_resolution_reg() call takes the spinlock, so > initialize it earlier. Fixes a warning at boot with lock debugging > enabled. > > Signed-off-by: Eric Anholt Fixes: 6adb730dc208 ("watchdog: bcm281xx: Watchdog Driver") Reviewed-by: Florian Fainelli > --- > drivers/watchdog/bcm_kona_wdt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/watchdog/bcm_kona_wdt.c b/drivers/watchdog/bcm_kona_wdt.c > index 6fce17d5b9f1..a5775dfd8d5f 100644 > --- a/drivers/watchdog/bcm_kona_wdt.c > +++ b/drivers/watchdog/bcm_kona_wdt.c > @@ -304,6 +304,8 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev) > if (!wdt) > return -ENOMEM; > > + spin_lock_init(&wdt->lock); > + > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > wdt->base = devm_ioremap_resource(dev, res); > if (IS_ERR(wdt->base)) > @@ -316,7 +318,6 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev) > return ret; > } > > - spin_lock_init(&wdt->lock); > platform_set_drvdata(pdev, wdt); > watchdog_set_drvdata(&bcm_kona_wdt_wdd, wdt); > bcm_kona_wdt_wdd.parent = &pdev->dev; > -- Florian