From: Milian Wolff <milian.wolff@kdab.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
kernel-team@lge.com, Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] perf report: Fix invalid warning on callchain param
Date: Wed, 17 May 2017 10:17:02 +0200 [thread overview]
Message-ID: <8594997.vKN7rfjkqZ@milian-kdab2> (raw)
In-Reply-To: <20170517070837.6263-1-namhyung@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On Wednesday, May 17, 2017 9:08:37 AM CEST Namhyung Kim wrote:
> Currently "perf report -g srcline --stdio" shows two warnings like
> below:
>
> Invalid callchain mode: srcline
> Invalid callchain order: srcline
>
> This is because it always tries to parse callchain mode, order, sort-key
> and value-type in a row. So even if 'srcline' is a valid sort-key, it
> shows invalid mode and order warnings.
>
> Change it to show a warning only if failed to parse the given token as
> any of valid parameter. Also code under try_numbers requires the token
> to be a number, it's good to show the warning there.
>
> Cc: Milian Wolff <milian.wolff@kdab.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Thank you, that annoyed me too. Tested and reviewed it, works fine - thanks!
Bye
--
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5903 bytes --]
prev parent reply other threads:[~2017-05-17 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 7:08 Namhyung Kim
2017-05-17 8:17 ` Milian Wolff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8594997.vKN7rfjkqZ@milian-kdab2 \
--to=milian.wolff@kdab.com \
--cc=acme@kernel.org \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®