From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751681AbdBBOqU (ORCPT ); Thu, 2 Feb 2017 09:46:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54830 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbdBBOqS (ORCPT ); Thu, 2 Feb 2017 09:46:18 -0500 Subject: Re: [PATCH] platform/x86: silead depends on I2C being built-in To: Arnd Bergmann , Darren Hart , Andy Shevchenko References: <20170202142744.3418986-1-arnd@arndb.de> Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org From: Hans de Goede Message-ID: <859e4199-8c8d-c1a8-6898-5ed4fe4572e4@redhat.com> Date: Thu, 2 Feb 2017 15:45:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170202142744.3418986-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 02 Feb 2017 14:45:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02-02-17 15:25, Arnd Bergmann wrote: > The new driver cannot be a loadable module, so if I2C is loadable, we get this > link error: > > drivers/platform/built-in.o: In function `silead_ts_dmi_init': > silead_dmi.c:(.init.text+0x2ef): undefined reference to `i2c_bus_type' > > This makes the Kconfig dependency stricter to require I2C=y. > > Fixes: 9eeda3897a85 ("platform/x86: add support for devices with Silead touchscreens") > Signed-off-by: Arnd Bergmann Thank you. Acked-by: Hans de Goede Regards. Hans > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index dd4952ac8797..a7fe9b9f975d 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 > > config SILEAD_DMI > bool "Tablets with Silead touchscreens" > - depends on ACPI && DMI && I2C && INPUT > + depends on ACPI && DMI && I2C=y && INPUT > ---help--- > Certain ACPI based tablets with Silead touchscreens do not have > enough data in ACPI tables for the touchscreen driver to handle >