From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012013.outbound.protection.outlook.com [40.107.209.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 220AD13B293 for ; Thu, 5 Feb 2026 03:53:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.13 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770263633; cv=fail; b=ZlO7SzU5DuX2QjO3iR/7tVKt/VcPF29hjmZSkGxPpmaWM9B3v5XtLuSfoqW5145rKbUGFpsT+Im1VqJFzRM85BpBEk8aRdRVSrHUvl8+fLujWTkCFMR5JvZug5u7h6mcYFPAqViRMC37uXgq2cTpLdBoX3tW/5cs/DymJ3IWB4Q= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770263633; c=relaxed/simple; bh=ZeAxhcNhK2IFWgcsZLfYHw35jr+zpXscNEkqTGOZo6A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=awN9GaRxdx8+j19A5TImdARxFEIt9VuoxC10okThHkZfRfq9/Nx00DCOh3VHrkF2Q5e0kaHYoHU2mJ0Y7kpQOoIVpOomJ3tIBk9cEqbQiNTM3Jrvu9mxSgeIF63B3xr4k45vRxiRbcQJT6eE3OkqPjJgNlEUIF2LaiQo5DQnXds= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ajcdoHuI; arc=fail smtp.client-ip=40.107.209.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ajcdoHuI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TTKhjLq8D65nTWJ1a3rROvglUkAC5Ky8aIFl1B/NF56qN7wF7ZRsN3nc2KIiXxlUvjE0QkwK2YdF0T2WuwXZkWgRPJhLecIckH7IHP7F1IyvafZUDOVyYaZCEbYovzopZiP3LADTDp0I5woX5S5vfmGpa4gdOgFXp2jX1TDUxtTxYHcLz9v2brpaJYn+mlD0BTlrOVfLPRhWZ+PsReG4GiRbF6tjlk4gPRx1sKabqbwQiLSeY02sCQSsnmtPIDH8eh1bsuk+tvXwkLgCp6RmYTQCA09bQudDLrRIuqGdGiuaoG7tYzD9MP0TQt8WROpmFoCPYKCN3lxtfrKr2rixBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g2EHkRTbjccN0EQ4ZRfyAxgCYFJ8OoijoJo3AylBZhU=; b=y7OAow2IMgHvNUWDM2L2lSvADvh+cQhTcOr9ENJ4bKlwu7jJVHdSeiGzP4NLJHfSJu2R+xG+aq+vgXmuc5/vlFgfLepDIDTxq1rbUett2QtV5kDPvWT6PnDKoriQxtOSGV2o/jqNsAnLGId718Q1NzuCKB1Z/0PvlUCTNRZoQMrdow6p5ZoqB6xi0grjBtedW14IRjhu7nzQ1Duli9tGRgF+ggQ5GD7PWh7FqMkcXmZBpAWzXdEeHQq5WZuKo9oSfEpFlj1RquTxvPTCIER1n6Prnp+GBs7+lgxiU2VqOxnxw5tWO5DVyP1aDkr+gv7r/U01DgDy/yCgBmDdL60RLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g2EHkRTbjccN0EQ4ZRfyAxgCYFJ8OoijoJo3AylBZhU=; b=ajcdoHuIrHbsAN/WwHkMnoPKOQCa8acvEK80lPW4C2+y9VQ2ddJ+f83rWzQDHYnibiGH1C7TzmUBwRXx1l3R7uLcug9J6zcZ54jhjd8PZy3RzEnrby7pJVGqaQPqo/o1MhoLOkKVPBX+qAS+fB5p1n6/KDgGhKwPr2L4zLmYz3gxn0xdkcBxR7/0p5qtp6WKMjL3Td0wQB0Q8yoNhxfnWiFk6o9dBI54IEBbzR92Ozunt6DdXFv6hvm/ajmVLGCVZ8vre1ZgIxzDAWBip4dX7OePb1AF/ifScN08JwhZtToRzWtnUOVnDIgo0jXaMYmacnlHpRccgxX7x7a6EFXiQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by IA1PR12MB6650.namprd12.prod.outlook.com (2603:10b6:208:3a1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.12; Thu, 5 Feb 2026 03:53:50 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9587.013; Thu, 5 Feb 2026 03:53:49 +0000 From: Zi Yan To: Miaohe Lin , jane.chu@oracle.com Cc: "David Hildenbrand (arm)" , =?utf-8?b?5piv5Y+C5beu?= , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Matthew Wilcox Subject: Re: WARNING in memory_failure() at include/linux/huge_mm.h:635 triggered Date: Wed, 04 Feb 2026 22:53:48 -0500 X-Mailer: MailMate (2.0r6290) Message-ID: <85CB7DEA-79EE-43EE-BA9B-C2AC81F6FA02@nvidia.com> In-Reply-To: References: <1db245a8-f9ab-42e4-8cc6-cc7562961921@kernel.org> <48978612-6933-4897-85DD-6740B6C8570B@nvidia.com> <25CA4D90-A24E-49C6-92D2-08080EC81466@nvidia.com> <032058DC-CD8D-406A-B986-740E41C834B2@nvidia.com> <61BBEF63-20D6-4671-B7F7-F015D49B2080@nvidia.com> <1bfc9e64-2961-4d2c-a6c3-fb123f66e6cc@kernel.org> <94DAA11B-597F-4F8F-AFFF-9D7626A7C091@nvidia.com> <7d5754dd-8cf5-41f3-a767-271b28b1f63c@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL0PR1501CA0035.namprd15.prod.outlook.com (2603:10b6:207:17::48) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|IA1PR12MB6650:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a68ef33-5545-48cf-676c-08de646a2bae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cm01S2FIWVpGV3Q3ODlEWGw5WGQ3Y0pFalltejROeG9IVW5XY0ZMUEJHSk1E?= =?utf-8?B?aDJaL2JDRzVJU3gxZk50dmJNTGplZy9KVGdwRTFDdkUyWFNudDZZd0R1OGZG?= =?utf-8?B?ZlR0YWRleUNjdnV3TW1Mc050UllxTm1haHh3RkY4UzVRMjdvTW1SaDBvL3FF?= =?utf-8?B?cUhxRXRoZURjVVFLaVdhQ1lnQkxlOWhOSnYwZUhjR2Z1aG15VXJUb211RVJJ?= =?utf-8?B?MXNQdllnbmJpVVQzOGp0cEdEdFdYMHE4bXhFclhGYjhCcUp0dkRQWmdSeG1W?= =?utf-8?B?MmNPMTB5UHFJVnpaTk4yZWp4Z3lsUG4zdXBiUGJCK2VidC9kU0kvQzBrMjA4?= =?utf-8?B?ZG1vM2lwSjE3Vjlub3FHWEZWdjNwbTNqNnZ5YjJkbEx1SEVQcXp1dDZrL2Z0?= =?utf-8?B?VlFETjRnZWRqdit0U3Zrdno2TkFTZk00N1h6dFJYQjl0OFR3ek9RdnRIc0Fy?= =?utf-8?B?TlEvTjdLMUlXcnpCSDYrbzJ5QzVJR3RJZGw3RlBsRG1Ld3FOckhyZndpd3Uz?= =?utf-8?B?cFZiMDRTNmErclBtdVVRQUQ3U3dFSktrRDRBOUx0aWFQbGhxNWFHM2xVdG1o?= =?utf-8?B?WCtWNVphZmcxRnRHRENWMWxmbTlBZE4xRjZpalVmRUx5OHdOVGlDMFA2UVR6?= =?utf-8?B?VHgzKzNaQnhScVl5OVZQT1RBYnd3bjd3MmpaRjhHVG11TTdNTlRKZjVtbDZU?= =?utf-8?B?bHRNcjJORHprN3crNmFkTktEb2lRVlozcDFQRVhWeGtVY09NbncycHVYaWt1?= =?utf-8?B?aHNxRVAzTm53YXJ1Uk10RVB6Yjh0RWhWeUJYUzlJV21VQlhmeVY0Ulp5ZEtT?= =?utf-8?B?b25majdIU2wzQkJVVWRONU9XbGVHYnlyaUN2NGl4ZHd6SWdJdnVMcnA5NnZD?= =?utf-8?B?V2ZYUFJScTdCRktONjlmS0hsbmtGVUNaQUJwTFdRS3FnTGkrbmZYazFiY3NI?= =?utf-8?B?SDZpYXlnUUtibm4wOXU5Rk92RjI2L290SndrMHBSR1ZNL2d3Z0NYZTAwcHRW?= =?utf-8?B?V2Vjb2VYOUY4R2V5c2FUOFBqRTNDWHpxWUNicmFHNEdKWmRNMnRFWk91eXl0?= =?utf-8?B?SEh5VkVadU5NbzA0R3JIYit2MDAxY203RHB0QnZzZWR4dmJpUjlNSUEzWXRv?= =?utf-8?B?cTJuRENNUk1JRWhQcFBoTS9tY1YwVHlxRmcya2lSckphK3luckZCb3RLaHF6?= =?utf-8?B?Qmd1Zk14blUxZjNkV2JCb3dGVnRKRHlGZmhDQzVCUkZBdFJIVmduTnp4aUEy?= =?utf-8?B?cU9PVXBzckxsUXFlbDRSZno1ZHB4N2dURXFxQ3Ezdk5ZYXc2TUMwTitoMGlw?= =?utf-8?B?UEFESW9xdTBHUGpITzRLcjdRUVptUU5GMVJqUERZeDdWNWx6dm5NbEYxbjd0?= =?utf-8?B?Y2c4SU9TRUhvdFc3N3Nibk1KbXYyVThtdUN0ejNLUFM3WXdZQ3NCMW9qZXha?= =?utf-8?B?V0ZpNVBpVC9QVlB6SGg3L01ZUm15UEJUS3NQYXZOWFF3RUdIM0FZZEtMVlA3?= =?utf-8?B?R0M5Vk8zTTNkU3pnTEJlWTdHUmE4cVFqQUIyQzJueHoyTEtBYTRNTkFkY2dN?= =?utf-8?B?TUJ5aDltZXZsOHdPUVdQNm11S25RSm5uUm1EVXB2TytRTzZMTDZoVVZGWHo1?= =?utf-8?B?Wk9HZjZlUWlxRzlhNHVwbDNGWG1USjlXRGhjMjJzbXdaNU9aQTVuTk9VWnFm?= =?utf-8?B?TUZtWDlIRUdmdUNBaGJUb1l2VTg0d2FIREltWCtVSWhhcHVlT2NRRTNWbWhv?= =?utf-8?B?bGxzWjIyY1ZMTU5lWngrb3FGRHY3QmxSQXNoUkFyaE43eDRrVitpek9sRWtI?= =?utf-8?B?M2ZhVzRMS0FQV2RKWkxldGdESHJaS2FvTW5KTE9uWTVpTDdMNEdhZnBuODEz?= =?utf-8?B?cEtJczBPeW9Fd1NDMUF0SzJleVk2SHZ0T3JmYUptb0d1RUttejhERURIWnFO?= =?utf-8?B?UnE1RzMzTTJvNzFwTG8zT3h3ZFFaMVpDekduRzkxcXlkODJ0L0IxUXdMUmRu?= =?utf-8?B?TlVtY0thYkVjRjE2T1ZBUGM1SmZGbHoxK0ZtRkprUjFYTnJhbCsxYndQOWRR?= =?utf-8?B?aFh3RURkUTZZTGZpNFY0dTVHQ0FVTU84RDJFQjh6SXAxaDBPOE82R2ZaNkZa?= =?utf-8?Q?+B+w=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDh1d0xGc1JpeGhGckoxRVVySmF0SzI3VXFuZkNCbldPQVh2a1NCWFZadnd5?= =?utf-8?B?c3VVWWRFaHRSVTFKSzlJdWtTSUFKV3AzRWZydFBnd2d4bTBOWTJXd3o1bkJS?= =?utf-8?B?M08yVUZGQU9BWmtBRGlCdFZmZVRnU0kvcVZZdk5lRjY1RE9yQlNjNjFSTEhQ?= =?utf-8?B?cW1DaVdoZEgwbWpnY01SblRIMDBEOWdVRWxGeHdrYUFSKzA5NWFpU0doQXNu?= =?utf-8?B?ckVudjh0Y2JjOW50WXVYa1lBNW5Kd3NMWTZkOUxWaVFib0FUK1o3VDhUREFx?= =?utf-8?B?Nk50R3RIaUFwZVo5cllwZHRnQ1dDajFiUGFLaFFpRm9meWlLUys4L1J6K3J1?= =?utf-8?B?Njg5bHlpOTRhdHM5TjQwWG4xdWh3OGdTK2sreEZ5UzZJMmR4WEdNR3ZQRS92?= =?utf-8?B?WDFVSlY3OUdQV0dNZ2lVWG5YZjJEY2lwa2MvOUM2S0hYcTJXS3oyYUJITE9a?= =?utf-8?B?bzVqaWVKa1NKUGZiZGkwcUJtOXNzNjl0SEpiMS9XMnQ1K0tGY2xXWEV5QUgw?= =?utf-8?B?b1ZuUS9uMGo2Y1VWL01LN294ODhQenZFSVBGMWlhWXRab0VrQWpiNkJDRmJ1?= =?utf-8?B?WXA1cjRjNUFBTlh6OUZIOFhZVVkzQmtEazlZaFZHUFNmMUpucFQwREhXbElX?= =?utf-8?B?TThHYXY0c251OVdneWRheG8xckZsRkc5SlIvWm1ZQmsrd1d2TDlPd3BPUmgw?= =?utf-8?B?d2FpcGJlcTRkYnFEZmVrdXFXZ2NETVBTdUVKUENqcE5LMmNiS3lUeEdYVWZE?= =?utf-8?B?VUUvOEg3REYwZllpakFlUmVMbmhpSkEwWVE3ajM0eElEOS8xNDEzbGpvbWUw?= =?utf-8?B?RmZYRGNoc3pwUjJUQjJpaktkMGJOamQweWZFc2tWRGE0SzNkOXp1OXYyT1BW?= =?utf-8?B?ZWtjMmtVOFJKeFJwODJQZWo3YTIwU3Y3VWNOZm1uaWYva2NSczhvQXM5N05I?= =?utf-8?B?QTRmN0E0Nit6Z3BTTzFRZnNmLzJRVUpqMUJLUDZlREx1V2ptbjhqdzJjTjNt?= =?utf-8?B?eURIejliUnlrSWZTM0IvRFB4aUJGYTdWa3lEZWVETUZhY09hWkVpMElJQVpR?= =?utf-8?B?bkZtYUsyUmtxUTJZenl4TEZBNU5JaWpxY1hlaWJNZjRuVzRkUGNuMDhNQytJ?= =?utf-8?B?N2JaYXAxYlgyVVpQMXJ2VjFHd3E2OVNJWDN6MHNsTGxHVGs5T0h2SGZzWnFj?= =?utf-8?B?Uk9VVW5HdW05T2FvTmVsQS91UTkxSUJvNEFLMERDMFBsY0NjSFFMeCsrb2FH?= =?utf-8?B?UHFQMVVHN3FwK2hreVJpcG1TaWtJWVFPeDVYMEltd0g2RHFHWXI1bnVHM3lp?= =?utf-8?B?MnpoZ0d6OU9aMXEveUUrZGUzVmd6UkRtaUZ3MFF6RlFGaExFdXFXanBvOWd0?= =?utf-8?B?bGg3UWgyckxyMTNMM3F3b1VJTWdiRkJWWjUyU00vcVZzMklQUUF1dnpSSXJ5?= =?utf-8?B?blphVzNwNDZCOGNNeEdPOHpubUtzRTcwN3FqQU1SVmo0OGVPaWhwWHRPVDk4?= =?utf-8?B?Z25VTVFNeU1EaFJSKy9Tbm9HbVRHK3BzZ0NmOEpiaEVBWmp3NXYwZDZoUXpL?= =?utf-8?B?ZkNoangxSTlsTk14SnAzRG5QTWtGOWJnbENhNlE4a0hMYTQ0MTh1VnN2UFlR?= =?utf-8?B?THhaNW4xRmdWLytZYVpwU2RVS0phWm5UVXlWckcrWEJyTEFVbHVsQTVTZFpt?= =?utf-8?B?Y1FjTW0rK0JydTByZU1OdGlDK0VJYzFnS2gyL2c1TWd0WmRqN0hPbkNQck5r?= =?utf-8?B?MnA5SWNzRTVaS2piN0Y0b3ZGWmloc00vVGtaMHlER0N5dTRGSWlRcHV1TmpP?= =?utf-8?B?M3hCcGUzbDBuenFjbEpWaUxiVjJGalRhcS9FR3J3S1B6Z2gvVUFPTjNMREFF?= =?utf-8?B?djZLakwzOVVYcTR2T0I2bE9XdzlrSDhmekQ5cC9uemZYY05XOHEzMTNDSG1O?= =?utf-8?B?RVdiM3NFNmdqNmdRU3JPWnFYbURjSXlFQlF6Sm96SVhjTmsybDd2b2hGRks2?= =?utf-8?B?QjFtUGtnWWcvZmVxa3B1UmVWU3JyR0ZOZGpnSkY4OE45dXdSWFRyZkQrM3VN?= =?utf-8?B?eDVXNzhtNS9LN1FiR3I1RUhHUGhXc2M2VUREeUtQQ1R1a2x1dkw0R2ErcmEx?= =?utf-8?B?QkRGVE0zeUxkOVRpMTBBUTBPc0lNejM5OXhVN1AyYllIWTY4Ums3ak9BblhD?= =?utf-8?B?WWM2aytRckFBUThmeloxaFNSbFk5UzdldTdBSm5CV1NTalYvSXVVZmwrMEQz?= =?utf-8?B?UGdvekFsYmp1QllhY2pNMTdMQWNrUnRxYm9vNGYxQkl5NS83KzJ2bURWNWlQ?= =?utf-8?Q?vGcai1XycdpU9i7Umg?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a68ef33-5545-48cf-676c-08de646a2bae X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2026 03:53:49.6196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UATcaccIQIIpkaPS5snKwRk7dWdJGFhggxYFhTOfyyYF/TWj5Nk5zGN8rQl2H3K3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6650 On 4 Feb 2026, at 22:21, Miaohe Lin wrote: > On 2026/2/5 10:00, jane.chu@oracle.com wrote: >> >> >> On 2/4/2026 1:41 PM, Zi Yan wrote: >>> On 4 Feb 2026, at 16:37, David Hildenbrand (arm) wrote: >>> >>>> On 2/4/26 22:08, Zi Yan wrote: >>>>> On 4 Feb 2026, at 14:18, David Hildenbrand (arm) wrote: >>>>> >>>>>> On 2/4/26 18:41, Zi Yan wrote: >>>>>>> >>>>>>> >>>>>>> More details: >>>>>>> later at sg_vma_fault(), the driver just handles a page fault by su= pplying >>>>>>> a subpage from a pre-allocated compound page[3]. We then get a larg= e folio >>>>>>> without !CONFIG_TRANSPARENT_HUGEPAGE. >>>>>> >>>>>> We can identify such non-folio (but compound) things by looking at P= G_large_rmappable IIRC. >>>>> >>>>> OK, back to the issue. The patch below should fix the issue? >>>>> >>>>> Hi =E6=98=AF=E5=8F=82=E5=B7=AE, >>>>> >>>>> Can you test it? >>>>> >>> >>> >>>> I think you have to test for folio_test_large() before testing folio_t= est_large_rmappable(). >>> >>> Oh, forgot that. Thanks. >>> >>> >>> =C2=A0From 8dda4bba9964890462eca3ef3cce57bb4fab8313 Mon Sep 17 00:00:00= 2001 >>> From: Zi Yan >>> Date: Wed, 4 Feb 2026 16:04:19 -0500 >>> Subject: [PATCH] mm/memory_failure: reject unsupported non-folio compou= nd page >>> >>> Signed-off-by: Zi Yan >>> --- >>> =C2=A0 mm/memory-failure.c | 8 ++++++-- >>> =C2=A0 1 file changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >>> index 825c706ac576..137c67fda57e 100644 >>> --- a/mm/memory-failure.c >>> +++ b/mm/memory-failure.c >>> @@ -2440,9 +2440,13 @@ int memory_failure(unsigned long pfn, int flags) >>> >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 folio =3D page_folio(p); >>> >>> -=C2=A0=C2=A0=C2=A0 /* filter pages that are protected from hwpoison te= st by users */ >>> +=C2=A0=C2=A0=C2=A0 /* >>> +=C2=A0=C2=A0=C2=A0=C2=A0 * filter pages that are protected from hwpois= on test by users >>> +=C2=A0=C2=A0=C2=A0=C2=A0 * or unsupported non folio compound pages >>> +=C2=A0=C2=A0=C2=A0=C2=A0 */ >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 folio_lock(folio); >>> -=C2=A0=C2=A0=C2=A0 if (hwpoison_filter(p)) { >>> +=C2=A0=C2=A0=C2=A0 if (hwpoison_filter(p) || >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (folio_test_large(folio) &&= !folio_test_large_rmappable(folio))) { >> >> Just curious, would this filter out pte-mapped THP/mTHP folios? No. All folios (including pre-mapped/mTHP ones) are large_rmappable. > > Thanks all. > > memory_failure() can meet various types of folios. So in get_hwpoison_pag= e(), > HWPoisonHandlable() and PageHuge() are used to check whether the folio ca= n > be handled. But in madvise(MADV_HWPOISON) scene, MF_COUNT_INCREASED is se= t in > flag, so this check is skipped and warning triggered. Might HWPoisonHandl= able() > check be always used to make sure the folio is in sane types? Something l= ike > below (i.e. remove the MF_COUNT_INCREASED check before calling get_hwpois= on_page): > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 825c706ac576..ba4231858a36 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2411,31 +2411,29 @@ int memory_failure(unsigned long pfn, int flags) > * In fact it's dangerous to directly bump up page count from 0, > * that may make page_ref_freeze()/page_ref_unfreeze() mismatch. > */ > - if (!(flags & MF_COUNT_INCREASED)) { > - res =3D get_hwpoison_page(p, flags); > - if (!res) { > - if (is_free_buddy_page(p)) { > - if (take_page_off_buddy(p)) { > - page_ref_inc(p); > - res =3D MF_RECOVERED; > - } else { > - /* We lost the race, try again */ > - if (retry) { > - ClearPageHWPoison(p); > - retry =3D false; > - goto try_again; > - } > - res =3D MF_FAILED; > - } > - res =3D action_result(pfn, MF_MSG_BUDDY, = res); > + res =3D get_hwpoison_page(p, flags); > + if (!res) { > + if (is_free_buddy_page(p)) { > + if (take_page_off_buddy(p)) { > + page_ref_inc(p); > + res =3D MF_RECOVERED; > } else { > - res =3D action_result(pfn, MF_MSG_KERNEL_= HIGH_ORDER, MF_IGNORED); > + /* We lost the race, try again */ > + if (retry) { > + ClearPageHWPoison(p); > + retry =3D false; > + goto try_again; > + } > + res =3D MF_FAILED; > } > - goto unlock_mutex; > - } else if (res < 0) { > - res =3D action_result(pfn, MF_MSG_GET_HWPOISON, M= F_IGNORED); > - goto unlock_mutex; > + res =3D action_result(pfn, MF_MSG_BUDDY, res); > + } else { > + res =3D action_result(pfn, MF_MSG_KERNEL_HIGH_ORD= ER, MF_IGNORED); > } > + goto unlock_mutex; > + } else if (res < 0) { > + res =3D action_result(pfn, MF_MSG_GET_HWPOISON, MF_IGNORE= D); > + goto unlock_mutex; > } > > folio =3D page_folio(p); > > Thanks. > . This makes sense to me. And it gets rid of the warning as well. Can you send a proper patch of this? Feel free to add Reviewed-by: Zi Yan Tested-by: Zi Yan to it. Thanks. -- Best Regards, Yan, Zi