mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nicolas@fjasle.eu>
Subject: Re: [PATCH v2] kbuild: fix linux-headers package build when $(CC) cannot link userspace
Date: Wed, 12 Feb 2025 23:30:48 -0800	[thread overview]
Message-ID: <85a035e7-fb06-434c-ba26-f813fc4f3200@oss.qualcomm.com> (raw)
In-Reply-To: <20250213062645.325632-1-masahiroy@kernel.org>

On 2/12/2025 10:26 PM, Masahiro Yamada wrote:
> Since commit 5f73e7d0386d ("kbuild: refactor cross-compiling
> linux-headers package"), the linux-headers Debian package fails to
> build when $(CC) cannot build userspace applications, for example,
> when using toolchains installed by the 0day bot.
> 
> The host programs in the linux-headers package should be rebuilt using
> the disto's cross-compiler, ${DEB_HOST_GNU_TYPE}-gcc instead of $(CC).
> Hence, the variable 'CC' must be expanded in this shell script instead
> of in the top-level Makefile.
> 
> Commit f354fc88a72a ("kbuild: install-extmod-build: add missing
> quotation marks for CC variable") was not a correct fix because
> CC="ccache gcc" should be unrelated when rebuilding userspace tools.
> 
> Fixes: 5f73e7d0386d ("kbuild: refactor cross-compiling linux-headers package")
> Reported-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
> Closes: https://lore.kernel.org/linux-kbuild/CAK7LNARb3xO3ptBWOMpwKcyf3=zkfhMey5H2KnB1dOmUwM79dA@mail.gmail.com/T/#t
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Thanks for the quick fix!

Tested-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>


      reply	other threads:[~2025-02-13  7:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-13  6:26 Masahiro Yamada
2025-02-13  7:30 ` Jeff Johnson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85a035e7-fb06-434c-ba26-f813fc4f3200@oss.qualcomm.com \
    --to=jeff.johnson@oss.qualcomm.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas@fjasle.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®