From: "Arnd Bergmann" <arnd@arndb.de>
To: "Marc Zyngier" <maz@kernel.org>, "Arnd Bergmann" <arnd@kernel.org>
Cc: "Oliver Upton" <oliver.upton@linux.dev>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Shaoqin Huang" <shahuang@redhat.com>,
"Ricardo Koller" <ricarkol@google.com>,
"Gavin Shan" <gshan@redhat.com>,
"James Morse" <james.morse@arm.com>,
"Suzuki K Poulose" <suzuki.poulose@arm.com>,
"Zenghui Yu" <yuzenghui@huawei.com>,
"Cornelia Huck" <cohuck@redhat.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: kvm: avoid overflow in integer division
Date: Thu, 18 May 2023 14:14:46 +0200 [thread overview]
Message-ID: <85a2cc47-dd95-4c39-82ab-8bf7a2a1589a@app.fastmail.com> (raw)
In-Reply-To: <86lehmksf1.wl-maz@kernel.org>
On Thu, May 18, 2023, at 09:30, Marc Zyngier wrote:
> On Wed, 17 May 2023 21:23:39 +0100,
> Arnd Bergmann <arnd@kernel.org> wrote:
>> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
>> index 3386bd28d267..6db9ef288ec3 100644
>> --- a/arch/arm64/kvm/mmu.c
>> +++ b/arch/arm64/kvm/mmu.c
>> @@ -92,8 +92,8 @@ static int kvm_mmu_split_nr_page_tables(u64 range)
>> int n = 0;
>>
>> if (KVM_PGTABLE_MIN_BLOCK_LEVEL < 2)
>> - n += DIV_ROUND_UP_ULL(range, PUD_SIZE);
>> - n += DIV_ROUND_UP_ULL(range, PMD_SIZE);
>> + n += DIV_ROUND_UP(range, PUD_SIZE);
>> + n += DIV_ROUND_UP(range, PMD_SIZE);
>> return n;
>> }
>
> This is against -next, right? Oliver, I assume you'll take this as a
> fix for Ricardo's series?
Yes, correct, I saw it after rebasing my tree from 6.4-rc2 to the
latest -next.
Arnd
next prev parent reply other threads:[~2023-05-18 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 20:23 Arnd Bergmann
2023-05-18 7:30 ` Marc Zyngier
2023-05-18 12:14 ` Arnd Bergmann [this message]
2023-05-18 17:45 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85a2cc47-dd95-4c39-82ab-8bf7a2a1589a@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cohuck@redhat.com \
--cc=gshan@redhat.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=ricarkol@google.com \
--cc=shahuang@redhat.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®