From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756158AbcIFNvf (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Sep 2016 09:51:35 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:64333 "EHLO
        mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754815AbcIFNv2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Sep 2016 09:51:28 -0400
X-AuditID: cbfec7f5-f792e6d0000013f5-21-57cec9c7bec4
Subject: Re: [PATCH] mfd: exynos-lpass: mark PM functions as __maybe_unused
To: Arnd Bergmann <arnd@arndb.de>
References: <20160906132432.2083493-1-arnd@arndb.de>
Cc: Lee Jones <lee.jones@linaro.org>, Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Beomho Seo <beomho.seo@samsung.com>,
        Inha Song <ideal.song@samsung.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
Message-id: <85bba0e5-cd64-a8e8-b576-acc094003004@samsung.com>
Date: Tue, 06 Sep 2016 15:50:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-version: 1.0
In-reply-to: <20160906132432.2083493-1-arnd@arndb.de>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsVy+t/xq7rHT54LN1h8QdLi76Rj7BanP21j
        t9j19z6jxZu3a5gs+h+/ZrY4f34Du8X9r0cZLTY9vsZqcXnXHDaLGef3MTlwefz+NYnRY9Oq
        TjaPO9f2sHlsXlLvsaX/LrtH35ZVjB6fN8kFsEdx2aSk5mSWpRbp2yVwZTTc2MhaMImtoqf3
        DFMD40TWLkZODgkBE4n903cyQdhiEhfurWfrYuTiEBJYyihx9eoqKOc5o8T9E7fZQaqEBbwl
        pjY1MYLYIgKKElNfPGMGsYWAJi3vesQC0sAscJ1J4vLF42Ar2AQMJXqP9gE1cHDwCthJ7D4n
        ChJmEVCVWHXuMNgcUYEIiVurPoLZvAKCEj8m32MBsTkFTCVud/5nAmllFtCTuH9RCyTMLCAv
        sXnNW+YJjAKzkHTMQqiahaRqASPzKkbR1NLkguKk9FwjveLE3OLSvHS95PzcTYyQmPi6g3Hp
        MatDjAIcjEo8vBW7z4ULsSaWFVfmHmKU4GBWEuHtPgEU4k1JrKxKLcqPLyrNSS0+xCjNwaIk
        zjtz1/sQIYH0xJLU7NTUgtQimCwTB6dUA6OCp+f664nLcvpfrTxwYQVftpz6nL86zUfuTuZc
        WJ3WKN763U3fkCPz9cuO+TVu89M4+h/uWxigsG9S14YN69SETCao/EyKDyiLOrtn8ladAsvD
        4vqmGSsn5R+NuZnha3skO0K0z+rHdpUray5uklVhnevbedzwVP8V2WvulrHXUs2CKxzrZZVY
        ijMSDbWYi4oTAVhht9GFAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/06/2016 03:24 PM, Arnd Bergmann wrote:
> The newly added exynos lpass driver produces a build warning when
> CONFIG_PM is disabled since the only callers of exynos_lpass_disable
> are under an #ifdef:
> 
> drivers/mfd/exynos-lpass.c:93:13: error: 'exynos_lpass_disable' defined but not used [-Werror=unused-function]
>  static void exynos_lpass_disable(struct exynos_lpass *lpass)
> 
> This removes the #ifdef and replaces it with __maybe_unused annotations
> so the compiler can leave out the unused code silently with less
> room for mistakes.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 36c26760bba8 ("mfd: Add Samsung Exynos Low Power Audio Subsystem driver")

Thanks for fixing this,

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>