From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752222AbdKZQ4H (ORCPT ); Sun, 26 Nov 2017 11:56:07 -0500 Received: from ale.deltatee.com ([207.54.116.67]:50324 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322AbdKZQ4F (ORCPT ); Sun, 26 Nov 2017 11:56:05 -0500 To: Julia Lawall Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft , Joe Perches References: <20171126054037.9743-1-logang@deltatee.com> From: Logan Gunthorpe Message-ID: <85bdbab8-8b7e-91a9-7199-a0e39041aef1@deltatee.com> Date: Sun, 26 Nov 2017 09:55:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 68.147.191.165 X-SA-Exim-Rcpt-To: joe@perches.com, apw@canonical.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/11/17 10:51 PM, Julia Lawall wrote: > I don't understand at all the second sentence. Are you staying with the > same call, or moving on to other calls? Also, it would be the call that > is split over multiple lines, not the function split over multiple lines. Yes, you are correct it should be "call" instead of "function". > I think this would have been much easier with Cocccinelle where the code > is parsed and the control-flow graph is available to see whether there is > a pr_cont afterwards. But if it works, then it is surely good enough. I don't disagree at all. However, to my knowledge, not a lot of kernel developers run a set of coccinelle scripts on their change sets. The point is to catch these mistakes before the patch is submitted. Logan