mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: Olivier Moysan <olivier.moysan@st.com>, <a.hajda@samsung.com>,
	<narmstrong@baylibre.com>, <Laurent.pinchart@ideasonboard.com>,
	<jonas@kwiboo.se>, <jernej.skrabec@siol.net>, <airlied@linux.ie>,
	<daniel@ffwll.ch>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>, <benjamin.gaignard@st.com>,
	<alexandre.torgue@st.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-stm32@st-md-mailman.stormreply.com>, <robh+dt@kernel.org>,
	<mark.rutland@arm.com>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/3] dt-bindings: display: sii902x: Change audio mclk binding
Date: Thu, 4 Jul 2019 11:25:25 +0300	[thread overview]
Message-ID: <85c5d6a8-95d9-d4c0-fb33-4a774caf0b5e@ti.com> (raw)
In-Reply-To: <1562082426-14876-3-git-send-email-olivier.moysan@st.com>

On 02/07/2019 18:47, Olivier Moysan wrote:
> As stated in SiL9022/24 datasheet, master clock is not required for I2S.
> Make mclk property optional in DT bindings.
> 
> Fixes: 3f18021f43a3 ("dt-bindings: display: sii902x: Add HDMI audio bindings")
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>

Looking the specs again it looks like the mclk is requred for sii9020,
but not for sii9022 and sii9024.

So I guess it is fine to accept the configurations without the mclk.

Reviewed-by: Jyri Sarha <jsarha@ti.com>

> ---
>  Documentation/devicetree/bindings/display/bridge/sii902x.txt | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation/devicetree/bindings/display/bridge/sii902x.txt
> index 2df44b7d3821..6e14e087c0d0 100644
> --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt
> @@ -26,9 +26,8 @@ Optional properties:
>  	- clocks: phandle and clock specifier for each clock listed in
>             the clock-names property
>  	- clock-names: "mclk"
> -	   Describes SII902x MCLK input. MCLK is used to produce
> -	   HDMI audio CTS values. This property is required if
> -	   "#sound-dai-cells"-property is present. This property follows
> +	   Describes SII902x MCLK input. MCLK can be used to produce
> +	   HDMI audio CTS values. This property follows
>  	   Documentation/devicetree/bindings/clock/clock-bindings.txt
>  	   consumer binding.
>  
> 


-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply	other threads:[~2019-07-04  8:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 15:47 [PATCH 0/3] drm/bridge: sii902x: fix audio mclk management Olivier Moysan
2019-07-02 15:47 ` [PATCH 1/3] drm/bridge: sii902x: fix missing reference to mclk clock Olivier Moysan
2019-07-04  8:03   ` Jyri Sarha
2019-07-05 12:24   ` Philippe CORNU
2019-07-12 10:31   ` Andrzej Hajda
2019-07-02 15:47 ` [PATCH 2/3] dt-bindings: display: sii902x: Change audio mclk binding Olivier Moysan
2019-07-04  8:25   ` Jyri Sarha [this message]
2019-07-05 12:35   ` Philippe CORNU
2019-07-12 10:31   ` Andrzej Hajda
2019-07-02 15:47 ` [PATCH 3/3] drm/bridge: sii902x: make audio mclk optional Olivier Moysan
2019-07-04  8:29   ` Jyri Sarha
2019-07-05 12:36   ` Philippe CORNU
2019-07-12 10:45   ` Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85c5d6a8-95d9-d4c0-fb33-4a774caf0b5e@ti.com \
    --to=jsarha@ti.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=alexandre.torgue@st.com \
    --cc=benjamin.gaignard@st.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@siol.net \
    --cc=jonas@kwiboo.se \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mark.rutland@arm.com \
    --cc=narmstrong@baylibre.com \
    --cc=olivier.moysan@st.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®