From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Everest K.C." <everestkc@everestkc.com.np>
Cc: dpenkler@gmail.com, gregkh@linuxfoundation.org,
skhan@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gpib: Change return type and error code of fluke_get_dma_residue
Date: Thu, 17 Oct 2024 12:00:59 +0300 [thread overview]
Message-ID: <85cb4aba-60ca-4fea-8d1c-dd01578357b5@stanley.mountain> (raw)
In-Reply-To: <20241017082022.16874-1-everestkc@everestkc.com.np>
On Thu, Oct 17, 2024 at 02:20:22AM -0600, Everest K.C. wrote:
> fluke_get_dma_residue() returns unsigned int with -1 as error code.
> This error cannot be caught.
> Fix this by changing the return type of the function to int and
> returning the error code, that was captured.
>
> Fixes: 55936779f496 ("staging: gpib: Add Fluke cda based cards GPIB driver")
> Signed-off-by: Everest K.C. <everestkc@everestkc.com.np>
> ---
So like quite often we would merge a patch like this, because there's nothing
wrong with it and why not? It's a step in the right direction. But actually
in this case could you fix the caller as well?
Do it all in the same patch. It's the one *whole* thing per patch rule.
regards,
dan carpenter
next prev parent reply other threads:[~2024-10-17 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 8:20 Everest K.C.
2024-10-17 9:00 ` Dan Carpenter [this message]
2024-10-17 9:26 ` Everest K.C.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85cb4aba-60ca-4fea-8d1c-dd01578357b5@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=everestkc@everestkc.com.np \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®