mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kurt Garloff <kurt@garloff.de>
To: Trond Myklebust <trondmy@hammerspace.com>,
	"NeilB@suse.de" <NeilB@suse.de>,
	"Anna.Schumaker@Netapp.com" <Anna.Schumaker@Netapp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: NFS 4.2 client support broken on 5.10.5
Date: Fri, 8 Jan 2021 16:49:53 +0100	[thread overview]
Message-ID: <85cd2357-b835-c8b4-ef98-e6b486abbbdc@garloff.de> (raw)
In-Reply-To: <927fcf61-7992-1b9f-ae39-c71d96323fbc@garloff.de>

Hi Trond,

Am 08.01.21 um 15:39 schrieb Kurt Garloff:
> Hi Trond,
>
> On 08/01/2021 12:58, Trond Myklebust wrote:
>> On Fri, 2021-01-08 at 12:41 +0100, Kurt Garloff wrote:
>>> [...]
>>> The kernel tree is on an NFS share, and I run 5.10.5 client kernel
>>> against the kernel NFS (4.2) server, running a 5.10.3 kernel.
>>>
>>> The issue does NOT occur on a 5.10.3 client kernel, but is easily
>>> reproducible on 5.10.5. Note that 5.10.5 on a local file system or
>>> against an NFSv3 server does not show the issue.
>>>
>>> Test program that reproduces this on the first pwrite64() is
>>> attached.
>>> Note that the call to ftruncate() is required to make the problem
>>> happen.
>>>
>>> I could go on bisecting this to a particular patch, but you'll
>>> probably be able to see right away what's wrong.
>>>
>> Hmm... If this is NFSv4.2 do you have READ_PLUS turned on or off in
>> .config? It really is not safe to enable READ_PLUS on 5.10 kernels
>> since that can cause random memory corruption.
> OK, it is turned on in my kernel -- looks like I have not read the
> warning in the config option help text carefully enough ...
>
> I'll test what happens if I switch it off and report back.

OK, I compiled a kernel without support for READ_PLUS
and the test program magically succeeds.

So take my report as input to the developers that work
on making READ_PLUS work. Maybe they want to add
my little program to their CI suite.

Thanks,

-- 
Kurt Garloff <kurt@garloff.de>, Cologne, Germany


      reply	other threads:[~2021-01-08 15:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 11:41 Kurt Garloff
2021-01-08 11:58 ` Trond Myklebust
2021-01-08 14:39   ` Kurt Garloff
2021-01-08 15:49     ` Kurt Garloff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85cd2357-b835-c8b4-ef98-e6b486abbbdc@garloff.de \
    --to=kurt@garloff.de \
    --cc=Anna.Schumaker@Netapp.com \
    --cc=NeilB@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®