From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BDED26ED40 for ; Mon, 29 Dec 2025 17:51:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767030669; cv=none; b=lp8fTv43rAInver017uyNcKW1WELa/EzEhv6JY6/eFZCrOvTDsg9tMmn3yOafnPApT+zi4KB+auFc4EJ6WyKErgIpPHLLj9rLfcey+sGQ3JXsNCZ3zWCZ0JCbOhTIMMrJDwraiE8NWulAsvHH9bxPrf0proLXljeQLvXUAD8CcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767030669; c=relaxed/simple; bh=1XKEYe/CZfMjAILCm6Rc6akSzewyZWwV/1d1uiX5tVY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LUlECviHxPgJGzj/sTFW6U3gW1BLceSvWIJwqo3lpdk1Jh+dbytetisle8WehZo54MjNrrKBJhl47NkzswVLvkXaTvdz2PrGHVY4sHuQ+sO/y8vNUO2aMTDzoNAnQ5jFpFrGYc+UUVN5NY6khEcn1H/xNV+zdfBFVJcWFZ9p/fI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=N+5+omA2; arc=none smtp.client-ip=209.85.160.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="N+5+omA2" Received: by mail-qt1-f195.google.com with SMTP id d75a77b69052e-4ee1879e6d9so106942941cf.1 for ; Mon, 29 Dec 2025 09:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1767030666; x=1767635466; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qBVKZpfddpe+Ns0g7Sdt2AUT7i0mQvsGFZpu3wnG5ic=; b=N+5+omA2FqqcOWQeEI8CB1prpL2hqjg7m1K7WGB5XljhLqiraQJNBk1lebUT7QGbKq 4dtK+3ceOaWInzFKo9zaTYpkzGH1PTE0eI8zmuLEg1tFcnOenDdMKCcm2edfzzj36wMp cerTMerLpIfBgy3usTxBkT9TScy5ILtXYk9lEI1F+Hdy09x0FsknD+cHlDVK9MRchndo NtXBlYU+0tM80wdEzDqndgxLmbpEQ0z/YV6Uh7nH7AegHjcWgirXlDdy2X13bl5ux2lQ JSz63wiOgXmaSwGEttovtr5cI1eRvo+h6TDMeCd3vf2DBpLZtb+CuKTwsUlS1AswHlDM /OSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767030666; x=1767635466; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qBVKZpfddpe+Ns0g7Sdt2AUT7i0mQvsGFZpu3wnG5ic=; b=mFPivEslNLOG5NBXayoMnYJKyFIsprKVBDKZLNUkyyOJAQaNKFAOODjNxadhMQwoau uHKND6ZyWi7Thbignn0EvNcZYUIunZq9nfEv7hlE+nI64QOmRyPI4FvvOMM592fCUg71 +3Dslm4Gb1B/rrrDbtq/tkae4XvLWNGKKOlR4yivD5/9KqlxyStZeMUaGqDb2smooDTg 6QSgNgDeTwRUpgBHtAFQolgKtnddmcbIDdzTprzrSR+glzrgdhA+yXu5jPkshBKGM7e2 AOiSSnP5w8jxG0hGxgD+d2bYW3gwwhsThJusL74VQ6/ArnLSA9seXp68oHrJvlX/V+WO Turw== X-Forwarded-Encrypted: i=1; AJvYcCXS47YXW0uv5IlnAme89dUB+FuK+XEqcS0TZU+bkeoG87LOQXDVGywtPbHUM2TV7PgQbSxVK5fBD9IOxWw=@vger.kernel.org X-Gm-Message-State: AOJu0YxKDD7KDllrwjW69Wxs1NaON1pj9ULCH1E59KRD5NbI/7SnF7iR QvJY8pfnUoCGxkWMO1giMNn38Rw5gha2XsYbnuA+a+WgSeMZ6p7oNKvpz/1ZK4bBccY= X-Gm-Gg: AY/fxX56ABdrt0EBKSEKxmttKjuSOol/0C8XhWkpwFyvxzchlzMgGyJ2mMGP3F4W2vN FwH8R2Zq4DOdirRhXH2CgoZ1v1i09Q86mQz2loO10M4pz8cmPc7neibnlSy436dDf5hv8FfdHdo ok5IykMFc7zFJaLSkEf32ngWkGsoWL++7WpDIszMBsIebyec0KfdAfZpVmv7/7LPWNTmDkcclMo Cm0u8j6C5emflyjrdVpRqTjCKpR7uY3WkgvmG7rytaqQganrklnckjrZn6aa9NpohHAq5it9T7m ZNAwjFaQmidLPPSOW5RU8zZ52KjfgS8k/0k++jgyaO8BUiFPMWC2kZQnQF2ecz70R+OE0JL8vFm 8ha7KclXlQX+QrggJVlBocO9IU9vWaE+3SPqLTV0vE0XmJthLdwYaF1gFOKbgjGjyJbvI24sNvH oIE8JXcMoNW3KGA4fO+Ka5yCFGUg== X-Google-Smtp-Source: AGHT+IEsUPVraniMkuTWC397mM/y7CFhjYXQZl0a4mAweu2WnF2gu2AEx/7J4AZSNaZAIT/grNKtTA== X-Received: by 2002:a05:622a:550f:b0:4ed:6e15:d2cc with SMTP id d75a77b69052e-4f4abd72019mr459440771cf.54.1767030666405; Mon, 29 Dec 2025 09:51:06 -0800 (PST) Received: from [10.211.55.5] ([209.81.125.20]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f4da7c31a1sm145471851cf.5.2025.12.29.09.51.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 09:51:06 -0800 (PST) Message-ID: <85d045be-7b18-4bf5-b6a1-09e723cad2a0@riscstar.com> Date: Mon, 29 Dec 2025 11:51:04 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] phy: Kconfig: spacemit: add COMMON_CLK dependency To: Vinod Koul Cc: neil.armstrong@linaro.org, dlan@gentoo.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, guodong@riscstar.com, linux-phy@lists.infradead.org, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot References: <20251226173228.2020411-1-elder@riscstar.com> Content-Language: en-US From: Alex Elder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/29/25 10:57 AM, Vinod Koul wrote: > On 26-12-25, 11:32, Alex Elder wrote: >> The SpacemiT PCIe PHY driver depends on the common clock framework. >> Not specifying that led to a failure when doing a COMPILE_TEST build >> for the SPARC architecture. >> >> Reported-by: kernel test robot >> Closes: https://lore.kernel.org/oe-kbuild-all/202512251903.sTVZgg6c-lkp@intel.com/ >> Signed-off-by: Alex Elder >> --- >> Note: This is based on phy/next, which I find doesn't currently build >> cleanly using "arch/riscv/configs/defconfig". > > I dont build rsicv, I should add that. What is the failure you see, > looking at changes I dont see anything that might break this The clock calls are not defined in the SPARC environment. phy-spacemit-k1-pcie.o: in function `k1_pcie_phy_pll_setup': phy-spacemit-k1-pcie.c:299: undefined reference to `devm_clk_hw_register' phy-spacemit-k1-pcie.c:306: undefined reference to `devm_clk_hw_get_clk' https://lore.kernel.org/oe-kbuild-all/202512251903.sTVZgg6c-lkp@intel.com/ (I now realize you can just click on the "Closes" link.) -Alex >> >> drivers/phy/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >> index aa2d30e0e3261..3bc7378ea8658 100644 >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig >> @@ -104,6 +104,7 @@ config PHY_NXP_PTN3222 >> config PHY_SPACEMIT_K1_PCIE >> tristate "PCIe and combo PHY driver for the SpacemiT K1 SoC" >> depends on ARCH_SPACEMIT || COMPILE_TEST >> + depends on COMMON_CLK >> depends on HAS_IOMEM >> depends on OF >> select GENERIC_PHY >> >> base-commit: 27287e3b52b5954b73203d32ee76ffd5f53f5074 >> -- >> 2.48.1 >