mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Karolina Drobnik <karolinadrobnik@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com, forest@alittletooquiet.net,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: vt6655: Rename byPreambleType field
Date: Fri, 15 Oct 2021 15:47:46 +0100	[thread overview]
Message-ID: <85dfe2c18e7ec4bd5ae67f7a81ab6197a82e0d86.camel@gmail.com> (raw)
In-Reply-To: <YWlj9x6kwYUT1jlQ@kroah.com>

Hi Greg,

On Fri, 2021-10-15 at 13:20 +0200, Greg KH wrote:
> Do not do multiple different things in the same commit and especially
> when you do not describe them in the changelog text.

I wasn't aware that changing this preamble-related variable would be
counted as a different thing. It makes sense, my bad.

Would you like me to amend the message to say that I also changed
`bb_get_frame_time` parameter or just drop this change completely?

Is there anything else I should address in my v3 patch?


Thanks,
Karolina


  reply	other threads:[~2021-10-15 14:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15 10:24 Karolina Drobnik
2021-10-15 11:20 ` Greg KH
2021-10-15 14:47   ` Karolina Drobnik [this message]
2021-10-15 15:10     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85dfe2c18e7ec4bd5ae67f7a81ab6197a82e0d86.camel@gmail.com \
    --to=karolinadrobnik@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®