From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2C89C432C2 for ; Thu, 26 Sep 2019 03:44:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A058B222BF for ; Thu, 26 Sep 2019 03:44:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391701AbfIZDo1 (ORCPT ); Wed, 25 Sep 2019 23:44:27 -0400 Received: from mail-sz.amlogic.com ([211.162.65.117]:18333 "EHLO mail-sz.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391561AbfIZDo1 (ORCPT ); Wed, 25 Sep 2019 23:44:27 -0400 Received: from [10.28.19.63] (10.28.19.63) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Thu, 26 Sep 2019 11:44:25 +0800 Subject: Re: [PATCH v2 3/3] reset: add support for the Meson-A1 SoC Reset Controller To: Kevin Hilman , Philipp Zabel , Neil Armstrong CC: Jianxin Pan , Rob Herring , Jerome Brunet , Hanjie Lin , , , References: <1569227661-4261-1-git-send-email-xingyu.chen@amlogic.com> <1569227661-4261-4-git-send-email-xingyu.chen@amlogic.com> <7hlfucrnlo.fsf@baylibre.com> From: Xingyu Chen Message-ID: <85eeda38-f04f-71d7-3c45-bc03e8c13953@amlogic.com> Date: Thu, 26 Sep 2019 11:44:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <7hlfucrnlo.fsf@baylibre.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.28.19.63] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Kevin Thanks for your reminder On 2019/9/26 6:57, Kevin Hilman wrote: > Hi Xingyu, > > Xingyu Chen writes: > >> The number of RESET registers and offset of RESET_LEVEL register for >> Meson-A1 are different from previous SoCs, In order to describe these >> differences, we introduce the struct meson_reset_param. >> >> Signed-off-by: Xingyu Chen >> Signed-off-by: Jianxin Pan >> Reviewed-by: Neil Armstrong > > Again, order here isn't quite right. Add the reviewed-by tags first, > and the sender should be the last sign-off. I will reorder Signed-off and Reviewed in next version > > Other than that, driver looks good. > > Reviewed-by: Kevin Hilman > Kevin > > . >