From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF5A7286898; Fri, 4 Jul 2025 10:25:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751624722; cv=none; b=c58aOh9vv9JeM8Nx2mRHL+ONRa3WyFY3q38kOuLbJzJR9zsRzF7DDIzThhc2blp7hvc8cEzm/q7iqyVS5Q0KvK6+awuKP75CLzWYOJcvHFGPoBsQevAr5I9skOJriAE9JYtPbVXN1Hcjgtij8SEmMrzFqVXXmIau6XLvyuXFLUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751624722; c=relaxed/simple; bh=+CXpUx6zZcO256ofhhwhvs6R9JR4HjYFe/ky01gIk5M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sIyOHBDP/Wmk/o7Ct+yxqR2X2kFPzlLCIEcWtgq/P3Gg4cbvbkxqvn6Ifi2+os46ucsuuXzmcwo1mUd398qQfidItheuXHaHxtp4VbyE/1jOKwJ2a8AyL+E/QUBHMc1EqTSWArRKbvXrK3Jrx/q5T4AUr0A++caj9L8GaPDRFsw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4bYVBg6lsLzYQtqs; Fri, 4 Jul 2025 18:25:15 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id C7F211A17CC; Fri, 4 Jul 2025 18:25:14 +0800 (CST) Received: from [10.67.109.79] (unknown [10.67.109.79]) by APP1 (Coremail) with SMTP id cCh0CgCXXjMJrGdo8tp7Ag--.21029S2; Fri, 04 Jul 2025 18:25:14 +0800 (CST) Message-ID: <85fc85e8-af92-4d58-8271-9bf4aeb0a63d@huaweicloud.com> Date: Fri, 4 Jul 2025 18:25:12 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH next] sched,freezer: prevent tasks from escaping being frozen To: Peter Zijlstra Cc: Michal Koutn?? , rafael@kernel.org, pavel@kernel.org, timvp@google.com, tj@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, lujialin4@huawei.com, chenridong@huawei.com References: <20250703133427.3301899-1-chenridong@huaweicloud.com> <8dae8006-e63d-467f-bb7c-e8470878e534@huaweicloud.com> <20250704075718.GA2001818@noisy.programming.kicks-ass.net> Content-Language: en-US From: Chen Ridong In-Reply-To: <20250704075718.GA2001818@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CM-TRANSID:cCh0CgCXXjMJrGdo8tp7Ag--.21029S2 X-Coremail-Antispam: 1UD129KBjvJXoWxWrW7tryfWw4UKrWrWF15urg_yoW5tr43p3 95Wa15Jw1Fqr1xZrnxtw4DZ3s8K3yq9r4UGrykCa4xJa1YqasxXr17C3yagF4jvry8KrnF qayjgr95Aw4UAaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7MxkF7I0En4kS 14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I 8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8 ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x 0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU1 7KsUUUUUU== X-CM-SenderInfo: hfkh02xlgr0w46kxt4xhlfz01xgou0bp/ On 2025/7/4 15:57, Peter Zijlstra wrote: > On Fri, Jul 04, 2025 at 11:11:52AM +0800, Chen Ridong wrote: > > Your patches are mangled; please educate your MUA. > Hi Peter, Thank you for your review and feedback Apologies for the formatting issues in the patch. >> --- a/kernel/freezer.c >> +++ b/kernel/freezer.c >> @@ -71,19 +71,20 @@ bool __refrigerator(bool check_kthr_stop) >> for (;;) { >> bool freeze; >> >> - raw_spin_lock_irq(¤t->pi_lock); >> - WRITE_ONCE(current->__state, TASK_FROZEN); >> - /* unstale saved_state so that __thaw_task() will wake >> us up */ >> - current->saved_state = TASK_RUNNING; >> - raw_spin_unlock_irq(¤t->pi_lock); >> - >> spin_lock_irq(&freezer_lock); >> - freeze = freezing(current) && !(check_kthr_stop && >> kthread_should_stop()); >> + freeze = (freezing(current) || !cgroup_thawed(current)) >> + && !(check_kthr_stop && kthread_should_stop()); > > This makes no sense to me; why can't this stay in cgroup_freezing()? > > Also, can someone please fix that broken comment style there. > The change relates to commit cff5f49d433f ("cgroup_freezer: cgroup_freezing: Check if not frozen"), which modified cgroup_freezing() to verify the FROZEN flag isn't set. The freezing(p) will return false if the cgroup is frozen. >> spin_unlock_irq(&freezer_lock); >> >> if (!freeze) >> break; >> >> + raw_spin_lock_irq(¤t->pi_lock); >> + WRITE_ONCE(current->__state, TASK_FROZEN); >> + /* unstale saved_state so that __thaw_task() will wake >> us up */ >> + current->saved_state = TASK_RUNNING; >> + raw_spin_unlock_irq(¤t->pi_lock); >> + > > And I'm not quite sure I understand this hunk either. If we bail out, > current->__state is reset to TASK_RUNNING, so what's the problem? The issue occurs in this race scenario: echo FROZEN > freezer.state freeze_cgroup() freeze_task() fake_signal_wake_up() // wakes task to freeze it In task context: get_signal try_to_freeze __refrigerator WRITE_ONCE(current->__state, TASK_FROZEN); // set TASK_FROZEN // race: cgroup state updates to frozen freezing(current) now return false // We bail out, the task is not frozen but it should be frozen. I hope this explanation clarifies the issue I encountered. Here's the corrected format patch: diff --git a/kernel/freezer.c b/kernel/freezer.c index 8d530d0949ff..16e98a6b497a 100644 --- a/kernel/freezer.c +++ b/kernel/freezer.c @@ -71,19 +71,20 @@ bool __refrigerator(bool check_kthr_stop) for (;;) { bool freeze; - raw_spin_lock_irq(¤t->pi_lock); - WRITE_ONCE(current->__state, TASK_FROZEN); - /* unstale saved_state so that __thaw_task() will wake us up */ - current->saved_state = TASK_RUNNING; - raw_spin_unlock_irq(¤t->pi_lock); - spin_lock_irq(&freezer_lock); - freeze = freezing(current) && !(check_kthr_stop && kthread_should_stop()); + freeze = (freezing(current) || !cgroup_thawed(current)) + && !(check_kthr_stop && kthread_should_stop()); spin_unlock_irq(&freezer_lock); if (!freeze) break; + raw_spin_lock_irq(¤t->pi_lock); + WRITE_ONCE(current->__state, TASK_FROZEN); + /* unstale saved_state so that __thaw_task() will wake us up */ + current->saved_state = TASK_RUNNING; + raw_spin_unlock_irq(¤t->pi_lock); + was_frozen = true; schedule(); } Best regards, Ridong