From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932190AbcIAHeb (ORCPT ); Thu, 1 Sep 2016 03:34:31 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:63467 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbcIAHe3 (ORCPT ); Thu, 1 Sep 2016 03:34:29 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: isdn@linux-pingi.de, davem@davemloft.net, dan.carpenter@oracle.com, mail@maciej.szmigiero.name, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH v3] mISDN: mark symbols static where possible Date: Thu, 01 Sep 2016 09:28:58 +0200 Message-ID: <8601808.6tDXj1LKbX@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1472710584-497-1-git-send-email-baoyou.xie@linaro.org> References: <1472710584-497-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:pACsWhny9EB8j8THTaf6PLZLbpNDDw3dzspffNTwltezZPFTxuG cYns+tz8LD7YAs22C/QbpzkSBo/aNs3xVzibr1jZTRFdbrBVvuPDsWJ5QtIzCTITWHldu7I jryCeplV++QOLEgYXjqyt8Xo7yl3VgYvGbELR3h795m/9aBetLmoyCu+QcCzImUG2WbZCGA /xHWP3XWR5Ka1wGTihjog== X-UI-Out-Filterresults: notjunk:1;V01:K0:1fUeZpU7gBY=:2FJC0/DkpBKUgzY+wuIZt6 fU+rNGuxvGENxdh6vBD1AmWxaBIuU7H57n558ddVeD39T6D2TGJODJKSSPibVc8fUSUxkMnbn SoVUvuujPHxZtPrp7RTym/k8U5b9/WTibObotRnQnv6c635dUd+9HHTt0WXw3VqePPCoRtWZA WXaa9wcY2DOlX6esI6OSVjo2727kHaHVbIlC+KMcHLPGikP6IMXP9OfsQKBAzbEGLju1bfKBG jyq8smyRDqDf4+yiq40DWk7vQodez9AQA5c49/0cX1oSlQFL0CHG/wBEMO4zcuhg5OJ4SSPl+ Nd+Jo5aGFkdvsoeIVIXT45+x99xuDSpvbTsUrcphC9MY5QS+9A6La65BxKd5HFTMBIiIszja1 0quvA6qki7s39Md4Lm/mcATOa+0pZ9izur99MO1GC2wh0fLdeyWu3yLrsfDWpFsDdYha1JzQJ wzVZvBHI6n+Ilf+rnKlywrZSnY26YxS6WWr1Rj1TJakRRHYZMI01BUngUrBHt9Q3RCqxneIUl 9QpAO4RAVS/LwcHToOS0dYur4gc0YdtgPO2q1Rimv/IZzqNM2+CmzOqZRbIs1PxqhiJvaKMn4 N/6UE2DMOmDumyFfqXzimcYjrooGAkzQEN2BNWjKM36FZCU7Lse9DvttHBIZXj6xZX/krEkp+ od3Uwd2JcIWJCdZLod1sJxV+gVQ8FhznQ7f7WNACVmiwcTdr7Eib8ykkq0l+cjSS1y6+MJl8c zgKOako8Vzx//WRw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, September 1, 2016 2:16:24 PM CEST Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/isdn/hardware/mISDN/hfcmulti.c:568:1: warning: no previous declaration for 'enablepcibridge' [-Wmissing-declarations] > drivers/isdn/hardware/mISDN/hfcmulti.c:574:1: warning: no previous declaration for 'disablepcibridge' [-Wmissing-declarations] > drivers/isdn/hardware/mISDN/hfcmulti.c:580:1: warning: no previous declaration for 'readpcibridge' [-Wmissing-declarations] > drivers/isdn/hardware/mISDN/hfcmulti.c:608:1: warning: no previous declaration for 'writepcibridge' [-Wmissing-declarations] > drivers/isdn/hardware/mISDN/hfcmulti.c:638:1: warning: no previous declaration for 'cpld_set_reg' [-Wmissing-declarations] > drivers/isdn/hardware/mISDN/hfcmulti.c:645:1: warning: no previous declaration for 'cpld_write_reg' [-Wmissing-declarations] > drivers/isdn/hardware/mISDN/hfcmulti.c:657:1: warning: no previous declaration for 'cpld_read_reg' [-Wmissing-declarations] > drivers/isdn/hardware/mISDN/hfcmulti.c:674:1: warning: no previous declaration for 'vpm_write_address' [-Wmissing-declarations] > drivers/isdn/hardware/mISDN/hfcmulti.c:681:1: warning: no previous declaration for 'vpm_read_address' [-Wmissing-declarations] > drivers/isdn/hardware/mISDN/hfcmulti.c:695:1: warning: no previous declaration for 'vpm_in' [-Wmissing-declarations] > drivers/isdn/hardware/mISDN/hfcmulti.c:716:1: warning: no previous declaration for 'vpm_out' [-Wmissing-declarations] > drivers/isdn/hardware/mISDN/hfcmulti.c:1028:1: warning: no previous declaration for 'plxsd_checksync' [-Wmissing-declarations] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > Acked-by: Arnd Bergmann