From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752436AbbFAJ0W (ORCPT ); Mon, 1 Jun 2015 05:26:22 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:60288 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752177AbbFAJ0N (ORCPT ); Mon, 1 Jun 2015 05:26:13 -0400 From: "Rafael J. Wysocki" To: eun.taik.lee@samsung.com Cc: "pavel@ucw.cz" , "len.brown@intel.com" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH v2] suspend/resume performance improvement Date: Mon, 01 Jun 2015 11:51:20 +0200 Message-ID: <8603263.ZsHYMQGz6a@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <671217780.313831433048860626.JavaMail.weblogic@epmlwas05b> References: <671217780.313831433048860626.JavaMail.weblogic@epmlwas05b> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, May 31, 2015 05:07:42 AM EunTaik Lee wrote: > When a task that calls state_store() to suspend > the device has used up most of its time slice, > suspend sometimes take too long. (User noticeable) How long? Perhaps this is not the only explanation of the delay? > Suspend/resume is a system wide operation. > So, instead of depending on a userspace task's time > slice, let kworker do the work to avoid a long wait > on the runqueue. > > Signed-off-by: Eun Taik Lee First, if you send a v2, please say what's changed since v1. Second, this most likely is hiding a problem of some sort and the theory about the time slice being used up entirely by the suspend process is not convincing. Also the patch duplicates exsiting functionality that should be extended instead if anything. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.