From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CFB41F37BA for ; Tue, 7 Jan 2025 14:54:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736261679; cv=none; b=kYI3e1YUM5Agm0V7TL4ps4bRf98/p6YVb1n6CqcFsRcvdmh2dInyUvzZUxNU086yABT9qvU46Gfc3vxFKI2wmHWaCoPkLG1s3l0+OeZQfIIjMWM3dC5vEpYkZrpn0Djc313XII0EtPLuHMj+tNeQN0KxuuLxYVp0iOwop0y031c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736261679; c=relaxed/simple; bh=4qDGKot4+n+hmLv0MOmy/gCToZuwpDeb4hHUjQcu/0A=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=mHBatg6yzElWXN5nQSRo+gSncrh9u5CEzwh9E4PR7zWB7cRe+Za6qmPXMWBvTdCgMRu/4hdoew4uNVjbqIm5/HesFTfPBd7usXvFRxwMOQeJbC65vT3epFUGFe30QvzWwFq0+WqTeAYCu6WkiRG+ltGr22LzDOh0I5bjSse0yy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kqQCpQmG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kqQCpQmG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D87EFC4CED6; Tue, 7 Jan 2025 14:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736261678; bh=4qDGKot4+n+hmLv0MOmy/gCToZuwpDeb4hHUjQcu/0A=; h=Date:Subject:To:References:From:Cc:In-Reply-To:From; b=kqQCpQmGLsvQSR/HC9Oz2TpSQdOMHOnnZ85XZRpIs6Id1l0EmJ+vwGKUealPi//XB GpkMstvUkECm6e4bXyUqPkcCueGD+tbsXeKvy2qM/SQo+ddvSwNq4jdWpMsL7xVowB +IfCI5zMjSTlhdONJ+nN1cMP9bpA2XnxGWJHWWkpeRgCmXDSMD54eM3Bs/aGvlQd9/ iHnapege6q6Y8w8hNCT/CZuLXOq38n1is5mVNAz0C8O2KyVhwNDxXsqRgiil3jB7zH mUZQCFgIo8ZReO6ZCt7vKX74mOVEUzxmpcKS9ZO0WNJCNcSpnickQTzB2wI9wk6N/9 IElP4IqiwuiwA== Message-ID: <86062930-7a8d-40c5-bbe5-b5bd62fc04ec@kernel.org> Date: Tue, 7 Jan 2025 22:54:33 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [f2fs-dev] [PATCH] f2fs: don't call block truncation for aliased file To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20250107023248.3702924-1-jaegeuk@kernel.org> Content-Language: en-US From: Chao Yu Cc: Chao Yu In-Reply-To: <20250107023248.3702924-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/1/7 10:32, Jaegeuk Kim via Linux-f2fs-devel wrote: > This patch should avoid the below warning which does not corrupt the metadata > tho. > > [ 51.508120][ T253] F2FS-fs (dm-59): access invalid blkaddr:36 > [ 51.508156][ T253] __f2fs_is_valid_blkaddr+0x330/0x384 > [ 51.508162][ T253] f2fs_is_valid_blkaddr_raw+0x10/0x24 > [ 51.508163][ T253] f2fs_truncate_data_blocks_range+0x1ec/0x438 > [ 51.508177][ T253] f2fs_remove_inode_page+0x8c/0x148 > [ 51.508194][ T253] f2fs_evict_inode+0x230/0x76c > > Fixes: 128d333f0dff ("f2fs: introduce device aliasing file") > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/node.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index c04ee1a7ce57..06313e1eb884 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1274,6 +1274,12 @@ int f2fs_remove_inode_page(struct inode *inode) > return err; > } > > + /* The aliase file must be truncated successfully. */ > + if (unlikely(IS_DEVICE_ALIASING(inode))) { > + f2fs_put_dnode(&dn); > + return 0; Do we need to keep calling truncate_node() for device alias inode in f2fs_remove_inode_page()? Thanks, > + } > + > /* remove potential inline_data blocks */ > if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) || > S_ISLNK(inode->i_mode))