From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: alina_yu@richtek.com, lgirdwood@gmail.com, broonie@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC
Date: Wed, 19 Jul 2023 09:43:03 +0200 [thread overview]
Message-ID: <860fffab-3c48-027d-aa2e-b15fc8f7a760@linaro.org> (raw)
In-Reply-To: <1689740741-29244-2-git-send-email-alina_yu@richtek.com>
On 19/07/2023 06:25, alina_yu@richtek.com wrote:
> From: alinayu <alina_yu@richtek.com>
>
> Add bindings for Richtek RTQ2208 IC controlled SubPMIC
>
> Signed-off-by: Alina Yu <alina_yu@richtek.com>
> ---
> v3
> - Fix some typos
> - Modify the descriptions for "richtek,mtp-sel"
> - Modify the node name to lowercase and remove underscore
> - Remove '|' from description
> - Remove "regulator-compatible" from property
> - Remove "regulator-state-mem" from pattern
> - Modify node name to generic one
> ---
> .../regulator/richtek,rtq2208-regulator.yaml | 206 +++++++++++++++++++++
> 1 file changed, 206 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
> new file mode 100644
> index 0000000..2fc92e5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
No improvements here.
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-19 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 4:25 [PATCH v3 0/2] Add Richtek RTQ2208 SubPMIC support alina_yu
2023-07-19 4:25 ` [PATCH v3 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC alina_yu
2023-07-19 7:43 ` Krzysztof Kozlowski [this message]
2023-07-19 8:46 ` Alina Yu
2023-07-19 8:57 ` Krzysztof Kozlowski
2023-07-19 4:25 ` [PATCH v3 2/2] regulator: rtq2208: Add Richtek RTQ2208 SubPMIC driver alina_yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=860fffab-3c48-027d-aa2e-b15fc8f7a760@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alina_yu@richtek.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®