From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCAB7C43460 for ; Fri, 7 May 2021 01:40:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A860C61090 for ; Fri, 7 May 2021 01:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233728AbhEGBlw (ORCPT ); Thu, 6 May 2021 21:41:52 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:58385 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229801AbhEGBlu (ORCPT ); Thu, 6 May 2021 21:41:50 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 57279581171; Thu, 6 May 2021 21:40:51 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Thu, 06 May 2021 21:40:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=4uW9jOMoITdaAvwQyvfGU+oL6PMdn7o JQL0rT3U+CBY=; b=hvFNRdFlIfXCWEteGHIMGamk7VtyaLR4+TmQByhOt3QFSc6 keFzQiqUFFy2GeFAM5Rns8CLA1V1zlnMHbrrBncnW4AEfwl0YiOSQ/fnq9m8NtbW 9rkDgiF2glUgKPFj/w5vfd5qzTCLdBnSrmYAVxUOyataboXuaqB6BXWKJOhItMLC bUdKiWOB3y2hMUG+9DR3BlFzLiZGd2xi5jAgpGD43Wc/z9t0BM5GTyTi9fFml/FC YjHGeJYMRhGAMtMGWjOfhiuFdI/IgeLRR/39MHIkHcp1UAcqiPSga+J6V2Aq3eBB 8/VnaSv/5INQxpcBF0MIYj47awt9RBhNaeoeqOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=4uW9jO MoITdaAvwQyvfGU+oL6PMdn7oJQL0rT3U+CBY=; b=D9lU4DHOT71DwkCU/OS8gc xFbih9sFE3tuzLCcwZJNQ8ZOvkGLAQlPdVXTGBGzeQjD1zoHWls01fwHAlkputEU fETzfWVvLDr3A9D8klywJ5FAPlQJMaKt9H5azbkjfqvfi/pRSoiulcuqpGREzt4f AHKGq4iyjqdhz4AMNUL/RQ7LSW6pA02pVz9I4jC5FdEMfRSwWYLLyVsJv6waOCQ3 7aL4gBU2K56cV3i92nEwKjNBJNp5fIboP7LniCv2ZvdoHhUzG4AGeN3A2R8LiQTF kY5wWVIz4VEJPvTxf5c2qF84G7wOrwlcAuNCycl7Eu0iVFzu+fHJCrRjD0eJLRgQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeguddggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhepuddttdekueeggedvtddtueekiedutdfguedutdefieeuteefieelteet vddthfeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id E7C5FA00079; Thu, 6 May 2021 21:40:48 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-448-gae190416c7-fm-20210505.004-gae190416 Mime-Version: 1.0 Message-Id: <8611c4a7-8c65-4d7d-90d5-37c80faa3142@www.fastmail.com> In-Reply-To: <20210506100312.1638-3-steven_lee@aspeedtech.com> References: <20210506100312.1638-1-steven_lee@aspeedtech.com> <20210506100312.1638-3-steven_lee@aspeedtech.com> Date: Fri, 07 May 2021 11:10:28 +0930 From: "Andrew Jeffery" To: "Steven Lee" , "Ulf Hansson" , "Rob Herring" , "Joel Stanley" , "Adrian Hunter" , "Philipp Zabel" , "Ryan Chen" , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list" Cc: "Ryan Chen" , "Chin-Ting Kuo" , "Hongwei Zhang" Subject: =?UTF-8?Q?Re:_[PATCH_v3_2/5]_ARM:_dts:_aspeed:_ast2600evb:_Add_comment_f?= =?UTF-8?Q?or_gpio_regulator_of_sdhci?= Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 May 2021, at 19:33, Steven Lee wrote: > Add the description for describing the AST2600-A2 EVB reference design of > GPIO regulators. > > Signed-off-by: Steven Lee > --- > arch/arm/boot/dts/aspeed-ast2600-evb.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > index 2772796e215e..1ae0facc3d5f 100644 > --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > @@ -104,6 +104,21 @@ > status = "okay"; > }; > > +/* > + * The signal voltage of sdhci0 and sdhci1 on AST2600-A2 EVB is able to be > + * toggled by GPIO pins. > + * In the reference design, GPIOV0 of AST2600-A2 EVB is connected to the > + * power load switch that providing 3.3v to sdhci0 vdd, GPIOV1 is connected to > + * a 1.8v and a 3.3v power load switch that providing signal voltage to > + * sdhci0 bus. > + * If GPIOV0 is active high, sdhci0 is enabled, otherwise, sdhci0 is disabled. > + * If GPIOV1 is active high, 3.3v power load switch is enabled, sdhci0 signal > + * voltage is 3.3v, otherwise, 1.8v power load switch will be enabled, > + * sdhci0 signal voltage becomes 1.8v. > + * AST2600-A2 EVB also support toggling signal voltage for sdhci1. > + * The design is the same as sdhci0, it uses GPIOV2 as power-gpio and GPIOV3 > + * as power-switch-gpio. > + */ Okay, I think the comment is in the right place, but I feel this patch should also add the regulator nodes and hook them up to the SDHCIs. Given Rob isn't super keen on a second example in the binding document I think you can just cut the example out and paste it in here. Andrew