From: "Ruslan U. Zakirov" <cubic@wr.miee.ru>
To: Adam Belay <ambx1@neo.rr.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH 2.5.65] pnp api changes to sound/isa/sb/es968.c
Date: Wed, 19 Mar 2003 18:09:23 +0300 [thread overview]
Message-ID: <861563974656.20030319180923@wr.miee.ru> (raw)
In-Reply-To: <Pine.LNX.4.53.0303190650530.28260@quinn.larvalstage.com>
JK> Following patch is to make ESS968 driver to work with PNP API.
[SNIP]
JK> +static int __devinit snd_es968_pnp_detect(struct pnp_card_link *card,
[SNIP]
Hello, Adam, Greg and other.
As I think in this section of kernel it's not necessarily to use
__devinit and __devexit.
Soundcards(and other devices) can't be HotPlug as I know.
And if we look at #define of this attributes, then we see that
it useless with not HotPlug devices.
180 #ifdef CONFIG_HOTPLUG
181 #define __devinit
182 #define __devinitdata
183 #define __devexit
184 #define __devexitdata
185 #else
186 #define __devinit __init
187 #define __devinitdata __initdata
188 #define __devexit __exit
189 #define __devexitdata __exitdata
190 #endif
And with changes from __init to __devinit and enabled CONFIG_HOTPLUG
we loose advantage of __init.
May be I've missed something?
Best regards, Ruslan.
next prev parent reply other threads:[~2003-03-19 14:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-19 12:03 John Kim
2003-03-19 12:11 ` Christoph Hellwig
2003-03-19 14:33 ` John Kim
2003-03-19 14:36 ` [PATCH 2.5.65] pnp api changes to sound/isa/sb/es968.c [rev2] John Kim
2003-03-19 14:38 ` [PATCH 2.5.65] pnp api changes to sound/isa/sb/es968.c Ruslan U. Zakirov
2003-03-19 15:09 ` Ruslan U. Zakirov [this message]
2003-03-19 16:22 ` John Kim
2003-03-19 22:15 ` Adam Belay
2003-03-19 22:08 ` Adam Belay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861563974656.20030319180923@wr.miee.ru \
--to=cubic@wr.miee.ru \
--cc=ambx1@neo.rr.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®