From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5059C43441 for ; Thu, 29 Nov 2018 07:14:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7457420863 for ; Thu, 29 Nov 2018 07:14:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7457420863 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727871AbeK2SSr (ORCPT ); Thu, 29 Nov 2018 13:18:47 -0500 Received: from foss.arm.com ([217.140.101.70]:57406 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726883AbeK2SSq (ORCPT ); Thu, 29 Nov 2018 13:18:46 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BE30FA78; Wed, 28 Nov 2018 23:14:21 -0800 (PST) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B0A4E3F5AF; Wed, 28 Nov 2018 23:14:16 -0800 (PST) Date: Thu, 29 Nov 2018 07:14:07 +0000 Message-ID: <861s74s6dc.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Bjorn Andersson Cc: Srinivas Kandagatla , sudeep.holla@arm.com, tglx@linutronix.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, rnayak@codeaurora.org, sboyd@kernel.org, srini@kernel.org, nicolas.dechesne@linaro.org, ctatlor97@gmail.com, vkoul@kernel.org Subject: Re: [RFC PATCH v3 3/4] irqchip: gic-v3: Add quirk for msm8996 secured registers In-Reply-To: <20181128233327.GE24969@minitux> References: <20181112103340.24702-1-srinivas.kandagatla@linaro.org> <20181112103340.24702-4-srinivas.kandagatla@linaro.org> <20181128233327.GE24969@minitux> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bjorn, On Wed, 28 Nov 2018 23:33:27 +0000, Bjorn Andersson wrote: > > On Mon 12 Nov 02:33 PST 2018, Srinivas Kandagatla wrote: > > > Access to GICR_WAKER is restricted on msm8996 SoC in Hypervisor. > > Its been more than 2+ years of wait for this to be fixed, which has > > no hopes to be fixed. This change was introduced for the "lead device" > > on msm8996 platform. It looks like all publicly available msm8996 and > > other qcom SoCs have this implementation. > > > > So add a quirk to not access this register on msm8996. > > > > With this quirk MSM8996 can at least boot out of mainline, > > which can help community to work with boards based on MSM8996 and other > > SoCs with have this restrictions. This Quirk is based on device tree > > compatible string. > > > > Without this patch Qualcomm DB820c board reboots when GICR_WAKER > > is accessed. > > > > Hi Srinivas, > > Given that the change request introducing this restriction looks quite > generic and that we've heard reports of other shipping platforms having > the same restriction, could we make this slightly more generic? s/restriction/gross bug/ > I.e. dropping the MSM8996 from the flag name and perhaps use a bool > property in devicetree to toggle the flag, instead of adding compatibles > as we figure out which Qualcomm platforms has this restriction. If we are to introduce a property, then it ought to be an erratum number (similar to what we do for the arch timer). Srinivas wasn't able to obtain one despite the defect having been known for years, so I guess this is out. Thanks, M. -- Jazz is not dead, it just smell funny.