From: Paolo Abeni <pabeni@redhat.com>
To: Marco Crivellari <marco.crivellari@suse.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Michal Hocko <mhocko@suse.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next 3/3] net: WQ_PERCPU added to alloc_workqueue users
Date: Thu, 11 Sep 2025 11:25:27 +0200 [thread overview]
Message-ID: <86200ee5-c0dc-4a70-823a-ae36b2e6c544@redhat.com> (raw)
In-Reply-To: <20250905090505.104882-4-marco.crivellari@suse.com>
On 9/5/25 11:05 AM, Marco Crivellari wrote:
> Currently if a user enqueue a work item using schedule_delayed_work() the
> used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
> WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
> schedule_work() that is using system_wq and queue_work(), that makes use
> again of WORK_CPU_UNBOUND.
> This lack of consistentcy cannot be addressed without refactoring the API.
>
> alloc_workqueue() treats all queues as per-CPU by default, while unbound
> workqueues must opt-in via WQ_UNBOUND.
>
> This default is suboptimal: most workloads benefit from unbound queues,
> allowing the scheduler to place worker threads where they’re needed and
> reducing noise when CPUs are isolated.
>
> This patch adds a new WQ_PERCPU flag at the network subsystem, to explicitly
> request the use of the per-CPU behavior. Both flags coexist for one release
> cycle to allow callers to transition their calls.
>
> Once migration is complete, WQ_UNBOUND can be removed and unbound will
> become the implicit default.
>
> With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
> any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
> must now use WQ_PERCPU.
>
> All existing users have been updated accordingly.
>
> Suggested-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
This and patch 1/3 do not apply cleanly to the net-next tree.
Please rebase and repost.
Also I suggest to split the wireless bit out of this series and send
them to the relevant sub tree, to avoid later merge issue.
Thanks,
Paolo
next prev parent reply other threads:[~2025-09-11 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 9:05 [PATCH net-next 0/3] net: replace wq users and add WQ_PERCPU to alloc_workqueue() users Marco Crivellari
2025-09-05 9:05 ` [PATCH net-next 1/3] net: replace use of system_unbound_wq with system_dfl_wq Marco Crivellari
2025-09-05 9:05 ` [PATCH net-next 2/3] net: replace use of system_wq with system_percpu_wq Marco Crivellari
2025-09-05 9:05 ` [PATCH net-next 3/3] net: WQ_PERCPU added to alloc_workqueue users Marco Crivellari
2025-09-08 16:44 ` Bobby Eshleman
2025-09-09 15:12 ` Marco Crivellari
2025-09-11 9:25 ` Paolo Abeni [this message]
2025-09-12 14:41 ` Marco Crivellari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86200ee5-c0dc-4a70-823a-ae36b2e6c544@redhat.com \
--to=pabeni@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mhocko@suse.com \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®