From: Dmitry Osipenko <digetx@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Yejune Deng <yejune.deng@gmail.com>,
balbi@kernel.org, p.zabel@pengutronix.de,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: core: Replace devm_reset_control_array_get()
Date: Thu, 7 Jan 2021 23:44:37 +0300 [thread overview]
Message-ID: <86247ea3-7f34-3d8f-eed9-350012384083@gmail.com> (raw)
In-Reply-To: <X/dfxmkAThIsMIoO@kroah.com>
07.01.2021 22:23, Greg KH пишет:
> On Thu, Jan 07, 2021 at 10:16:50PM +0300, Dmitry Osipenko wrote:
>> 03.11.2020 06:57, Yejune Deng пишет:
>>> devm_reset_control_array_get_optional_shared() looks more readable
>>>
>>> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
>>> ---
>>> drivers/usb/dwc3/core.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
>>> index 841daec..b87acf0 100644
>>> --- a/drivers/usb/dwc3/core.c
>>> +++ b/drivers/usb/dwc3/core.c
>>> @@ -1490,7 +1490,7 @@ static int dwc3_probe(struct platform_device *pdev)
>>>
>>> dwc3_get_properties(dwc);
>>>
>>> - dwc->reset = devm_reset_control_array_get(dev, true, true);
>>> + dwc->reset = devm_reset_control_array_get_optional_shared(dev);
>>> if (IS_ERR(dwc->reset))
>>> return PTR_ERR(dwc->reset);
>>>
>>>
>>
>> Greg / Felipe, could you please pick up this patch?
>>
>> I want to add devm_reset_control_array_get_exclusive_released() for
>> NVIDIA Tegra drivers and we need to get rid of all the open-coded
>> devm_reset_control_array_get() users in order to extend the reset API
>> sanely.
>
> Care to ack it or send a reviewed-by for it?
I sent r-b, thanks.
next prev parent reply other threads:[~2021-01-07 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 3:57 Yejune Deng
2021-01-07 19:16 ` Dmitry Osipenko
2021-01-07 19:23 ` Greg KH
2021-01-07 20:44 ` Dmitry Osipenko [this message]
2021-01-07 19:33 ` Dmitry Osipenko
2021-01-08 12:27 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86247ea3-7f34-3d8f-eed9-350012384083@gmail.com \
--to=digetx@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=yejune.deng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®