From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E86ACC7EE22 for ; Wed, 17 May 2023 03:27:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232304AbjEQD1B (ORCPT ); Tue, 16 May 2023 23:27:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232364AbjEQD0m (ORCPT ); Tue, 16 May 2023 23:26:42 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E827F3C07; Tue, 16 May 2023 20:26:30 -0700 (PDT) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34H2udgV032440; Wed, 17 May 2023 03:26:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=HmmCijOrb4yVr1n/H8Ak4RhDHBrqeGMDmGSnhfMa82w=; b=mHLUM9k2IusSTp2VAbBT+3xtmAxzU+9bMEf7BDE4w1Q9lZ7SyTh9iPRZwL+l9500xhEr txhnEwKrh5oNiaBSD0SYLfNq1FAdJs4NUiMpTlEH9E0ws1ndfkg3XCvJ8ede0sROTCfq ozXjxi125F14QuJ6L66pht1kinEg6N9+lh33zbFVq4CdUjUVI4PDnb62C09/kduCcqUP 0mGWpTob0+XMlM38WsW1XWLOq3AtCXcIQouLnfaHgPdU8bYZJ8ywG9+lhG3UlAG7gyou l4eIdnEV1CQ+e8lcan8WVuALyrYQDr4e6zNSSJW2tbxPAhoplBekYaFemyMfEf42+nXV sg== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qm74pa2de-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 03:26:13 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34H3Q05d017233 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 03:26:00 GMT Received: from [192.168.143.77] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Tue, 16 May 2023 20:25:59 -0700 Message-ID: <8626b0e2-66dd-73de-7b6e-8074e49b78d2@quicinc.com> Date: Tue, 16 May 2023 20:25:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v5 5/7] ufs: mcq: Added ufshcd_mcq_abort() Content-Language: en-US To: Stanley Chu CC: , , , , , , , , , , Alim Akhtar , "James E.J. Bottomley" , "Alice Chao" , Arthur Simchaev , open list References: <45743dac476e3b2bffb17eaf915fe7f48f87bbac.1683872601.git.quic_nguyenb@quicinc.com> From: "Bao D. Nguyen" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: YoUl1kE51kVV5JzF5s-G-6hw9Bt1ABN0 X-Proofpoint-ORIG-GUID: YoUl1kE51kVV5JzF5s-G-6hw9Bt1ABN0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-16_14,2023-05-16_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxscore=0 phishscore=0 malwarescore=0 impostorscore=0 adultscore=0 priorityscore=1501 bulkscore=0 mlxlogscore=930 suspectscore=0 clxscore=1011 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305170028 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/16/2023 8:15 PM, Stanley Chu wrote: > Hi Bao D. > >> @@ -7562,6 +7561,12 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) >> if (is_mcq_enabled(hba)) >> goto release; > > Should we remove the above lines because the code below will not be > executed in the MCQ path? Thanks Stanley. It was my silly rebase mistake :-(. I will fix it. Thanks, Bao > >> >> + if (is_mcq_enabled(hba)) { >> + /* MCQ mode. Branch off to handle abort for mcq mode */ >> + err = ufshcd_mcq_abort(cmd); >> + goto release; >> + } >> + >> /* Skip task abort in case previous aborts failed and report failure */ >> if (lrbp->req_abort_skip) { >> dev_err(hba->dev, "%s: skipping abort\n", __func__); >> -- >> 2.7.4 >>